Skip to content

Conversation

@dominiqueclarke
Copy link
Contributor

Summary

Converts the UI Monitor Management Locations combobox to checkboxes

Screen Shot 2022-02-07 at 9 28 37 PM

@dominiqueclarke dominiqueclarke added enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Feb 8, 2022
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner February 8, 2022 02:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke changed the title convert ui monitor management combobox to checkboxes [Uptime] Convert ui monitor management combobox to checkboxes Feb 8, 2022
@shahzad31
Copy link
Contributor

Looks ridiculously red on load , i think we should enforce validation on touch
image

@dominiqueclarke
Copy link
Contributor Author

Looks ridiculously red on load , i think we should enforce validation on touch image

@shahzad31 I agree, but I think it should be handled in a separate ticket, as it's currently the same way now. I'd be happy to pick it up though, as I agree it really annoys me. It's a leftover from when we didn't have as much control over validation with the fleet side of things.

Screen Shot 2022-02-09 at 7 34 46 AM

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, agreed to a follow up !!

@paulb-elastic
Copy link
Contributor

Much easier to interact with the locations now (especially when there will be multiple)
image

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 737.1KB 736.8KB -242.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 0766f18 into elastic:main Feb 11, 2022
@shahzad31 shahzad31 deleted the feature/ui-monitor-management-checkboxes branch February 11, 2022 08:33
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124917 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2022
@shahzad31 shahzad31 added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants