Skip to content

Conversation

@alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Feb 9, 2022

Summary

Fixes #124465

This PR adds a warning to the ES deprecations page if we detect the user has any remote clusters configured. It also adds a locator to the remote_clusters plugin, so that we can easily link to Remote Clusters from UA.

Screen Shot 2022-02-09 at 2 03 41 PM

How to test

  1. Navigate to Upgrade Assistant --> ES deprecations. Verify no warning message displays.
  2. Create a remote cluster(s). (See CCR readme in Kibana if you need help)
  3. Navigate to Upgrade Assistant --> ES deprecations. Verify warning message displays and link navigates to remote clusters UI.

@alisonelizabeth alisonelizabeth added release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// Feature:Upgrade Assistant v7.17.1 labels Feb 9, 2022
@@ -0,0 +1,44 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed pattern used in #109543

getRemoteClustersDetectedDescription: (remoteClustersCount: number) =>
i18n.translate('xpack.upgradeAssistant.esDeprecations.remoteClustersDetectedDescription', {
defaultMessage:
'You have {remoteClustersCount} {remoteClustersCount, plural, one {remote cluster} other {remote clusters}} configured. If you use cross-cluster search, note that 8.x can only search remote clusters 7.17 or later. If you use cross-cluster replication, a cluster that contains follower indices must run the same or newer version as the remote cluster.',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrodewig do you have bandwidth to review this text?

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth marked this pull request as ready for review February 10, 2022 13:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@jrodewig jrodewig added the ui-copy Review of UI copy with docs team is recommended label Feb 10, 2022
@alisonelizabeth
Copy link
Contributor Author

/cc @LeeDr

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this warning, @alisonelizabeth!
Tested locally and all worked as expected, code changes LGTM too 👍

…/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <[email protected]>
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #10 / Actions and Triggers app Connectors should test a connector and display a failure result

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
remoteClusters 123 124 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
remoteClusters 84.3KB 84.3KB -39.0B
upgradeAssistant 173.5KB 175.0KB +1.5KB
total +1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
remoteClusters 7.3KB 7.8KB +480.0B
upgradeAssistant 18.6KB 18.7KB +93.0B
total +573.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit 92c7cf8 into elastic:7.17 Feb 10, 2022
@alisonelizabeth alisonelizabeth deleted the ua/remote_cluster_check branch February 10, 2022 18:37
jrodewig added a commit to elastic/stack-docs that referenced this pull request Feb 10, 2022
Updates the upgrade guide to clarify BWC for CCS. Based on [the CCS docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-cross-cluster-search.html#ccs-supported-configurations), you can only search back one minor version.  This means a local 8.1 cluster can only search remote 8.0+ clusters.

Relates to elastic/kibana#125138 and #1970
jrodewig added a commit to elastic/stack-docs that referenced this pull request Feb 10, 2022
Updates the upgrade guide to clarify BWC for CCS. Based on [the CCS docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-cross-cluster-search.html#ccs-supported-configurations), you can only search back one minor version.  This means a local 8.1 cluster can only search remote 8.0+ clusters.

Relates to elastic/kibana#125138 and #1970

(cherry picked from commit 70964c7)
jrodewig added a commit to elastic/stack-docs that referenced this pull request Feb 10, 2022
Updates the upgrade guide to clarify BWC for CCS. Based on [the CCS docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-cross-cluster-search.html#ccs-supported-configurations), you can only search back one minor version.  This means a local 8.1 cluster can only search remote 8.0+ clusters.

Relates to elastic/kibana#125138 and #1970

(cherry picked from commit 70964c7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Upgrade Assistant release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// ui-copy Review of UI copy with docs team is recommended v7.17.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants