Conversation
…tion check handler (apache#3802)
…meets specific test requirements (apache#3754)
…d which meets specific test requirements (apache#3754)" This reverts commit e45f9b8.
…n successful shutdown (apache#3848)
… SCM when converting an unsecure cluster to secure (apache#3859)
…thy container states (apache#3837)
Co-authored-by: SaketaChalamchala <schalamchala@cloudera.com>
…r OMTenantCreateRequest (apache#3869)
This reverts commit b9a47f6.
…tream to OzoneCryptoInputStream (apache#3852)
…nds (apache#3892) * [wip] get rid of ozone-shell.log, suppress CLI log by default, except Freon * Output by org/apache/hadoop/fs/shell/Delete * Skip assertion for now, URL contains duplicate /
Owner
Author
|
@kerneltime This is an early review of OFS integration. Would be nice if you can have a look. I'll change the PR destination when HDDS-7231 is merged. |
Owner
Author
|
Immediate PR closed, moved to apache#3912. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Problem
The target of this task is to deprecate the
LookupFileinterface and useGetKeyInfofor the OFS use case.The gap between OFS and object storage use cases (like S3) is that due to a file system nature, OFS has to answer the file read requests from its client. A file read input is a file path and OFS needs to be able to decide if the given path is a valid file. To be specific, if the given path is not a file (but a directory), OFS should return an error. Reading empty files is a valid use case.
The
lookupKeyAPI returns the same content for an empty file and directory.Today, this is solved in Ozone by the separated
lookupFileAPI, detecting if the given key is a directory and throwing an error on server-side.GetKeyInforeplaceslookupKeyand inherits the same limit.Solution
To make
GetKeyInfoavailable for OFS, we can simply add to its response a field indicating if the key represents a directory or a file so that OFS client code can make the assertion.https://issues.apaceorg/jira/browse/HDDS-7419
How was this patch tested?
OFS integration test.