HDDS-7432. Move command summary into Commands object in CommandQueue#3901
Merged
sodonnel merged 1 commit intoapache:masterfrom Oct 28, 2022
Merged
HDDS-7432. Move command summary into Commands object in CommandQueue#3901sodonnel merged 1 commit intoapache:masterfrom
sodonnel merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Mentioning @swamirishi as it will not let me add you as a reviewer for some reason. |
aswinshakil
reviewed
Oct 27, 2022
Member
aswinshakil
left a comment
aswinshakil
left a comment
There was a problem hiding this comment.
I took a quick look at the changes. It looks good to me. Let @swamirishi also take a look as he reviewed the previous patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In HDDS-7402 it was suggested to move the CommandSummary tracking into the Commands inner class. This Jira is to make that small change.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7432
How was this patch tested?
Existing test added in HDDS-7402 covers this.