HDDS-7354. SchemaV3 blockData not deleted in table#3860
Merged
JacksonYao287 merged 2 commits intoapache:masterfrom Oct 20, 2022
Merged
HDDS-7354. SchemaV3 blockData not deleted in table#3860JacksonYao287 merged 2 commits intoapache:masterfrom
JacksonYao287 merged 2 commits intoapache:masterfrom
Conversation
kaijchen
approved these changes
Oct 19, 2022
Member
kaijchen
left a comment
kaijchen
left a comment
There was a problem hiding this comment.
LGTM, thanks @Xushaohong for the fix. Pending CI.
kaijchen
reviewed
Oct 19, 2022
...service/src/test/java/org/apache/hadoop/ozone/container/common/TestBlockDeletingService.java
Outdated
Show resolved
Hide resolved
Member
|
@captainzmc Please cherry-pick this to 1.3.0 release branch when it's merged. |
captainzmc
approved these changes
Oct 19, 2022
Member
captainzmc
left a comment
captainzmc
left a comment
There was a problem hiding this comment.
+1 the change looks good. Let's wait for CI to finish.
Contributor
|
thanks @kaijchen @captainzmc for the review , and @Xushaohong for this patch! i have committed it to master branch |
captainzmc
pushed a commit
that referenced
this pull request
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If using SchemaV3, the blocks are deleted on disk but the blockData is not deleted accordingly due to the misuse of the key in deleteViaTransactionStore.
Keep using the unified key format as V2 and V3 both delete blocks via TXN.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7354
How was this patch tested?
UT