Skip to content

HDDS-7351. Use jackson-bom to ensure consistent Jackson version#3856

Merged
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-7351
Oct 19, 2022
Merged

HDDS-7351. Use jackson-bom to ensure consistent Jackson version#3856
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-7351

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Oct 18, 2022

What changes were proposed in this pull request?

Simplify dependency management for Jackson2 artifacts by importing com.fasterxml.jackson:jackson-bom.

https://issues.apache.org/jira/browse/HDDS-7351

How was this patch tested?

Verified jackson version in dependency tree, e.g.

[INFO] org.apache.ozone:ozone-client:jar:1.3.0-SNAPSHOT
[INFO] \- org.apache.ozone:hdds-common:test-jar:tests:1.3.0-SNAPSHOT:test
[INFO]    +- com.fasterxml.jackson.core:jackson-annotations:jar:2.13.4:compile
[INFO]    \- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.13.4:compile
[INFO]       +- com.fasterxml.jackson.core:jackson-core:jar:2.13.4:compile
[INFO]       \- com.fasterxml.jackson.core:jackson-databind:jar:2.13.4.2:compile

https://github.com/adoroszlai/hadoop-ozone/actions/runs/3275722116

@adoroszlai adoroszlai self-assigned this Oct 18, 2022
@adoroszlai adoroszlai added the build Pull request that modifies the build process label Oct 18, 2022
smengcl
smengcl approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @adoroszlai for the improvement.

ayushtkn
ayushtkn approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adoroszlai adoroszlai merged commit d32e96c into apache:master Oct 19, 2022
@adoroszlai adoroszlai deleted the HDDS-7351 branch October 19, 2022 19:01
@adoroszlai
Copy link
Contributor Author

adoroszlai commented Oct 19, 2022

Thanks @ayushtkn, @smengcl for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

@smengcl smengcl smengcl approved these changes

Assignees

@adoroszlai adoroszlai

Labels

build Pull request that modifies the build process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adoroszlai @ayushtkn @smengcl