Skip to content

Comments

HDDS-7406. Remove unused the exception & improve debug log in KeyDeletingService#3880

Merged
kaijchen merged 1 commit intoapache:masterfrom
Xushaohong:HDDS-7406
Oct 27, 2022
Merged

HDDS-7406. Remove unused the exception & improve debug log in KeyDeletingService#3880
kaijchen merged 1 commit intoapache:masterfrom
Xushaohong:HDDS-7406

Conversation

@Xushaohong
Copy link
Contributor

What changes were proposed in this pull request?

  1. Remove unused the exception
  2. Improve debug log in KeyDeletingService
  3. Fix the copyright format
  4. Expand the parameter to erase the Raw use warning

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7406

How was this patch tested?

/

Copy link
Contributor

@myskov myskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some other issues with this class reported by sonar, but they can be solved in a different PR. LGTM

Copy link
Member

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement @Xushaohong, and thanks @myskov for reviewing.

@kaijchen kaijchen merged commit dd67faa into apache:master Oct 27, 2022
kaijchen pushed a commit that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants