Skip to content

Conversation

@navinko
Copy link
Contributor

@navinko navinko commented Oct 17, 2022

What changes were proposed in this pull request?

Updated exit status to zero for normal shutdown.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6930

Please replace this section with the link to the Apache JIRA)

How was this patch tested?

I did local testing and verified the logs for SCM shutdown.
Screenshot 2022-10-17 at 8 26 11 PM

@kerneltime
Copy link
Contributor

cc @devmadhuu

Copy link
Member

@aswinshakil aswinshakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Can we change the scope of this to include OM and Recon as well? As I have seen same shutdown error message there as well.

@navinko navinko changed the title HDDS-6930. SCM should not print ERROR and exit with code 1 on successful shutdown HDDS-6930. SCM , OM , RECON should not print ERROR and exit with code 1 on successful shutdown Oct 18, 2022
@navinko
Copy link
Contributor Author

navinko commented Oct 18, 2022

Thanks @kerneltime @aswinshakil for reviewing this . I have updated the Jira scope and code changes .

@navinko navinko changed the title HDDS-6930. SCM , OM , RECON should not print ERROR and exit with code 1 on successful shutdown HDDS-6930. SCM,OM,RECON should not print ERROR and exit with code 1 on successful shutdown Oct 18, 2022
@navinko navinko requested a review from aswinshakil October 18, 2022 10:35
@navinko navinko changed the title HDDS-6930. SCM,OM,RECON should not print ERROR and exit with code 1 on successful shutdown HDDS-6930. SCM,OM,RECON should not print ERROR and exit with code 1 on successful shutdown Oct 18, 2022
@aswinshakil
Copy link
Member

Thanks for the patch @navinko. Approved it. Looks like the CI is not triggered here, but looking at this CI passed.

@ChenSammi ChenSammi merged commit 1fa6d02 into apache:master Oct 20, 2022
@navinko
Copy link
Contributor Author

navinko commented Oct 20, 2022

Thanks @aswinshakil @ChenSammi @kerneltime @smengcl for reviewing and merging this PR

kaijchen pushed a commit that referenced this pull request Oct 25, 2022
errose28 added a commit to errose28/ozone that referenced this pull request Oct 26, 2022
* master: (718 commits)
  HDDS-7342. Move encryption-related code from MultipartCryptoKeyInputStream to OzoneCryptoInputStream (apache#3852)
  HDDS-7413. Fix logging while marking container state unhealthy (apache#3887)
  Revert "HDDS-7253. Fix exception when '/' in key name (apache#3774)"
  HDDS-7396. Force close non-RATIS containers in ReplicationManager (apache#3877)
  HDDS-7121. Support namespace summaries (du, dist & counts) for legacy FS buckets (apache#3746)
  HDDS-7258. Cleanup the allocated but uncommitted blocks (apache#3778)
  HDDS-7381. Cleanup of VolumeManagerImpl (apache#3873)
  HDDS-7253. Fix exception when '/' in key name (apache#3774)
  HDDS-7182. Add property to control RocksDB max open files (apache#3843)
  HDDS-7284. JVM crash for rocksdb for read/write after close (apache#3801)
  HDDS-7368. [Multi-Tenant] Add Volume Existence check in preExecute for OMTenantCreateRequest (apache#3869)
  HDDS-7403. README Security Improvement (apache#3879)
  HDDS-7199. Implement new mix workload Read/Write Freon command (apache#3872)
  HDDS-7248. Recon: Expand the container status page to show all unhealthy container states (apache#3837)
  HDDS-7141. Recon: Improve Disk Usage Page (apache#3789)
  HDDS-7369. Fix wrong order of command arguments in Nonrolling-Upgrade.md (apache#3866)
  HDDS-6210. EC: Add EC metrics (apache#3851)
  HDDS-7355. non-primordial scm fail to get signed cert from primordial SCM when converting an unsecure cluster to secure (apache#3859)
  HDDS-7356. Update SCM-HA.zh.md to match the English version (apache#3861)
  HDDS-6930. SCM,OM,RECON should not print ERROR and exit with code 1 on successful shutdown (apache#3848)
  ...

Conflicts:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/LegacyReplicationManager.java
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/TestLegacyReplicationManager.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants