HDDS-7361. Add general metrics for queues in Datanode#3863
Merged
sodonnel merged 5 commits intoapache:masterfrom Oct 28, 2022
Merged
HDDS-7361. Add general metrics for queues in Datanode#3863sodonnel merged 5 commits intoapache:masterfrom
sodonnel merged 5 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@sodonnel Could you help to review this PR? |
sodonnel
reviewed
Oct 25, 2022
Contributor
There was a problem hiding this comment.
Do you think we should append count / size / total to the end of the metric name? Most counters seem to end in something like this.
Contributor
|
I think this change looks mostly good. I had just one comment about the metrics name. Also, could you copy and paste an example of the metrics from a running docker-compose cluster and post in the PR so we can see what it is adding more easily? |
Contributor
Author
|
@sodonnel Added "size" to metrics names, please have a look. |
sodonnel
approved these changes
Oct 27, 2022
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
Thanks for taking on the changes. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This ticket is to add a general metrics class for the following queues in Datanodes
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7361
How was this patch tested?
unit test.