HDDS-7305. Fix Hadoop imports#3822
Merged
captainzmc merged 2 commits intoapache:masterfrom Oct 19, 2022
Merged
Conversation
Contributor
|
How did you identify the pom file changes? I understand the import change, but not sure how the pom file updates were speced out. |
Contributor
Author
Trial and error. Added the exclude, then resolved build failures. |
Contributor
Author
|
Thanks @captainzmc for reviewing and merging this. |
Member
|
Thanks @adoroszlai, I will cherry-pick this to release branch. |
captainzmc
pushed a commit
that referenced
this pull request
Oct 20, 2022
smengcl
pushed a commit
to smengcl/hadoop-ozone
that referenced
this pull request
Nov 2, 2022
(cherry picked from commit d5dc65e)
smengcl
pushed a commit
to smengcl/hadoop-ozone
that referenced
this pull request
Nov 3, 2022
(cherry picked from commit d5dc65e)
smengcl
pushed a commit
to smengcl/hadoop-ozone
that referenced
this pull request
Nov 9, 2022
(cherry picked from commit d5dc65e) (cherry picked from commit 66a2ea8f681685ea41483bc94a26c0bc92711ff5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Different Hadoop versions may not depend on all these libraries (or shade different Guava version), so using transitive dependency explicitly (via import) risks breaking with some version of Hadoop.
https://issues.apache.org/jira/browse/HDDS-7305
How was this patch tested?
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/3228775529