Conversation
441d648 to
28b571d
Compare
gregorydemay
left a comment
There was a problem hiding this comment.
We should also have a changelog for the SOL RPC canister and a corresponding bump of its version. As a base you can generate a changelog with git-cliff:
cd canister
git cliff --unreleased
This probably should be rerun to have the the latest merged PRs, no?
| [package] | ||
| name = "sol_rpc_client" | ||
| version = "1.0.0" | ||
| version = "2.0.0" |
There was a problem hiding this comment.
Does it need to be a major upgrade for the client? I guess the struct with the breaking change is exposed by the client.
libs/client/CHANGELOG.md
Outdated
| - Add build requirements to READMEs and rustdoc ([#169](https://github.com/dfinity/sol-rpc-canister/pull/169)) | ||
| - Add `Cargo.toml` linting to CI pipeline ([#155](https://github.com/dfinity/sol-rpc-canister/pull/155)) |
There was a problem hiding this comment.
I would not add those to the Changelog, I don't think there are relevant here.
libs/client/CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - Revert `sol_rpc_client` bump ([#178](https://github.com/dfinity/sol-rpc-canister/pull/178)) |
There was a problem hiding this comment.
I would remove this and the one below about PR 164.
libs/client/CHANGELOG.md
Outdated
|
|
||
| - Revert `sol_rpc_client` bump ([#178](https://github.com/dfinity/sol-rpc-canister/pull/178)) | ||
| - Migrate dependencies to `solana-sdk` repository ([#55](https://github.com/dfinity/sol-rpc-canister/pull/55)) | ||
| - Bump `sol_rpc_client` to `v1.0.1` ([#164](https://github.com/dfinity/sol-rpc-canister/pull/164)) |
There was a problem hiding this comment.
This shouldn't be here (if there was a 1.0.1 version there should be an entry for 1.0.1 in the changelog)
libs/types/CHANGELOG.md
Outdated
| - Add build requirements to READMEs and rustdoc ([#169](https://github.com/dfinity/sol-rpc-canister/pull/169)) | ||
| - Add `Cargo.toml` linting to CI pipeline ([#155](https://github.com/dfinity/sol-rpc-canister/pull/155)) |
There was a problem hiding this comment.
For the same reasons as above I would remove this.
libs/types/CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - Require HTTP outcall base fee ([#185](https://github.com/dfinity/sol-rpc-canister/pull/185)) |
There was a problem hiding this comment.
The changes made in that PR to that crate are not relevant, I would remove it.
| ### Changed | ||
|
|
||
| - Require HTTP outcall base fee ([#185](https://github.com/dfinity/sol-rpc-canister/pull/185)) | ||
| - Select supported providers based on successful responses ([#183](https://github.com/dfinity/sol-rpc-canister/pull/183)) |
There was a problem hiding this comment.
The relevant change to that crate is that there is a new method (rpc_provider_id), should be in the Added section.
libs/types/CHANGELOG.md
Outdated
| - Require HTTP outcall base fee ([#185](https://github.com/dfinity/sol-rpc-canister/pull/185)) | ||
| - Select supported providers based on successful responses ([#183](https://github.com/dfinity/sol-rpc-canister/pull/183)) | ||
| - Migrate dependencies to `solana-sdk` repository ([#55](https://github.com/dfinity/sol-rpc-canister/pull/55)) | ||
| - Improve docs for `InstallArgs` ([#172](https://github.com/dfinity/sol-rpc-canister/pull/172)) |
There was a problem hiding this comment.
I would remove it, this is not relevant regarding existing functionality.
28b571d to
862ae24
Compare
862ae24 to
015f445
Compare
|
Thank you for your review and input @gregorydemay! I hadn't marked the PR as ready for review yet because I was still trying to figure out a way to use This PR was closed in favor of #201 where I addressed your comments. |
🤖 New release
sol_rpc_types: 1.0.0 -> 2.0.0 (⚠ API breaking changes)sol_rpc_canister: 1.0.0sol_rpc_client: 1.0.0 -> 2.0.0 (✓ API compatible changes)sol_rpc_int_tests: 1.0.0sol_rpc_e2e_tests: 1.0.0basic_solana: 1.0.0⚠
sol_rpc_typesbreaking changesChangelog
sol_rpc_typessol_rpc_canistersol_rpc_clientsol_rpc_int_testssol_rpc_e2e_testsbasic_solanaThis PR was generated with release-plz.