Skip to content

chore: release#189

Closed
github-actions[bot] wants to merge 3 commits intomainfrom
release-plz-2025-07-17T21-43-19Z
Closed

chore: release#189
github-actions[bot] wants to merge 3 commits intomainfrom
release-plz-2025-07-17T21-43-19Z

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 17, 2025

🤖 New release

  • sol_rpc_types: 1.0.0 -> 2.0.0 (⚠ API breaking changes)
  • sol_rpc_canister: 1.0.0
  • sol_rpc_client: 1.0.0 -> 2.0.0 (✓ API compatible changes)
  • sol_rpc_int_tests: 1.0.0
  • sol_rpc_e2e_tests: 1.0.0
  • basic_solana: 1.0.0

sol_rpc_types breaking changes

--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field TransactionStatusMeta.cost_units in /tmp/.tmpJRMGUv/sol-rpc-canister/libs/types/src/solana/transaction/mod.rs:286
Changelog

sol_rpc_types

2.0.0 - 2025-07-31

Added

  • Select supported providers based on successful responses (#183)

Other

  • require HTTP outcall base fee (#185)
  • add optional cost_units to TransactionStatusMeta (#180)
  • migrate dependencies to solana-sdk repository (#55)
  • improve docs for InstallArgs (#172)
  • add build requirements to READMEs and rustdoc (#169)
  • add Cargo.toml linting to CI pipeline (#155)

sol_rpc_canister

[1.0.0] - 2025-06-13

Added

  • Add support for transactionDetails=accounts (#139)
  • Add support for rewards parameter for getBlock (#135)

sol_rpc_client

2.0.0 - 2025-07-31

Added

  • [breaking] add try_send method to SOL RPC client (#187)

Fixed

  • use correct fee for t-sig with local development key (#160)

Other

  • revert sol_rpc_client bump (#178)
  • migrate dependencies to solana-sdk repository (#55)
  • add build requirements to READMEs and rustdoc (#169)
  • bump sol_rpc_client to v1.0.1 (#164)
  • enable ed25519 feature in docs (#162)
  • add Cargo.toml linting to CI pipeline (#155)

sol_rpc_int_tests

1.0.0 - 2025-07-31

Added

  • [breaking] add try_send method to SOL RPC client (#187)
  • Select supported providers based on successful responses (#183)
  • add client method to estimate recent blockhash (#121)
  • add support for transactionDetails=accounts (#139)
  • add support for rewards parameter for getBlock (#135)
  • add client method to sign a transaction (#113)
  • Candid NonZeroU8 (#108)
  • add support for getSignaturesForAddress (#106)
  • add support for getSignatureStatuses RPC method (#96)
  • Add support for getRecentPrioritizationFees (#92)
  • add support for getTokenAccountBalance RPC method (#90)
  • Support method getBalance (#74)
  • add support for getTransaction RPC method (#68)
  • add getBlock RPC method (#53)
  • add sendTransaction RPC method (#59)
  • cycles cost (#52)
  • add getAccountInfo RPC method (#49)
  • client builder (#54)
  • round result from getSlot RPC method (#48)
  • use canhttp multi feature (#46)
  • Implement a method for making generic RPC request (#39)
  • Implement getSlot RPC method (#33)
  • add logging crate (#13)
  • add support for override providers (#12)
  • Add support for API keys (#10)
  • hard-code SOL RPC providers (#9)

Fixed

  • missing TraceHttp logs (#129)

Other

  • do not record metrics for requests with insufficient cycles (#184)
  • require HTTP outcall base fee (#185)
  • add more metrics (#144)
  • migrate dependencies to solana-sdk repository (#55)
  • integration test for fetching metrics (#143)
  • update dependencies and bump version (#145)
  • Revisit response size estimates (#147)
  • add missing documentation for getTransaction (#137)
  • add helper methods for request builders (#136)
  • add client builder helper methods for RpcConfig (#133)
  • bump version and use a release notes template (#130)
  • update Rust and libraries (#126)
  • add Chainstack RPC provider (#118)
  • end-to-end tests for sendTransaction (#104)
  • [breaking] use secure primitive types for Pubkey, Signature and Hash (#98)
  • use default commitment for client in solana_test_validator.rs (#97)
  • add integration test for getTokenAccountBalance (#95)
  • integration test for verifyApiKey (#82)
  • use canlog_derive and canlog from crates.io (#84)
  • (http-types) Remove http_types module and use external ic-http-types crate (#73)
  • use SOL RPC canister to fetch blockhash in integration test (#67)
  • use constant size JSON-RPC request ID (#62)
  • add NOTICE to Apache license (#60)
  • Forward calls through wallet canister (#40)
  • Add some tested RPC providers for Solana Mainnet and Devnet (#15)
  • Streamline providers (#32)
  • e2e test with Solana test validator (#20)
  • (deps) update Pocket IC (#31)
  • update rust toolchain to 1.85 (#21)
  • initial cargo workspace and build pipeline (#2)

sol_rpc_e2e_tests

1.0.0 - 2025-07-31

Added

  • [breaking] add try_send method to SOL RPC client (#187)
  • add client method to estimate recent blockhash (#121)
  • add client method to sign a transaction (#113)

Other

  • migrate dependencies to solana-sdk repository (#55)
  • add Cargo.toml linting to CI pipeline (#155)
  • update dependencies and bump version (#145)
  • durable nonce end-to-end test (#124)
  • add client builder helper methods for RpcConfig (#133)
  • bump version and use a release notes template (#130)
  • use threshold signing in end-to-end tests (#114)
  • end-to-end tests for sendTransaction (#104)

basic_solana

1.0.0 - 2025-07-31

Added

  • add client method to estimate recent blockhash (#121)
  • method to extract durable nonce from account (#117)
  • add client method to sign a transaction (#113)
  • add support for getTokenAccountBalance RPC method (#90)
  • default commitment level for SolRpcClient (#77)
  • Support method getBalance (#74)
  • add sendTransaction RPC method (#59)
  • Implement getSlot RPC method (#33)
  • basic Solana wallet example (#1)

Fixed

  • use correct Token Program for SPL in basic_solana (#128)

Other

  • improvements to SOL RPC docs (#158)
  • add Custom Solana network to basic_solana canister (#171)
  • migrate dependencies to solana-sdk repository (#55)
  • add build requirements to READMEs and rustdoc (#169)
  • more links (#168)
  • improve basic_solana Candid documentation (#161)
  • use build script for basic_solana deployment (#156)
  • add support for running basic_solana locally and on mainnet (#91)
  • update dependencies and bump version (#145)
  • add client builder helper methods for RpcConfig (#133)
  • use 2-out-of-3 threshold consensus for basic_solana (#132)
  • bump version and use a release notes template (#130)
  • update Rust and libraries (#126)
  • [breaking] use secure primitive types for Pubkey, Signature and Hash (#98)
  • remove unused serde_json dependency in basic_solana (#94)
  • clean-up TODOs (#81)
  • transfer of SPL token in basic_solana (#78)
  • integration tests for the basic_solana example (#75)
  • use SOL RPC canister in basic_solana example (#69)
  • (deps) Bump base64 from 0.13.1 to 0.22.1 (#11)
  • (deps) use new ic-ed25519 crate (#7)


This PR was generated with release-plz.

@github-actions github-actions bot force-pushed the release-plz-2025-07-17T21-43-19Z branch 2 times, most recently from 441d648 to 28b571d Compare July 30, 2025 11:44
Copy link
Contributor

@gregorydemay gregorydemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also have a changelog for the SOL RPC canister and a corresponding bump of its version. As a base you can generate a changelog with git-cliff:

cd canister
git cliff --unreleased

This probably should be rerun to have the the latest merged PRs, no?

[package]
name = "sol_rpc_client"
version = "1.0.0"
version = "2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be a major upgrade for the client? I guess the struct with the breaking change is exposed by the client.

Comment on lines 13 to 14
- Add build requirements to READMEs and rustdoc ([#169](https://github.com/dfinity/sol-rpc-canister/pull/169))
- Add `Cargo.toml` linting to CI pipeline ([#155](https://github.com/dfinity/sol-rpc-canister/pull/155))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not add those to the Changelog, I don't think there are relevant here.


### Changed

- Revert `sol_rpc_client` bump ([#178](https://github.com/dfinity/sol-rpc-canister/pull/178))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this and the one below about PR 164.


- Revert `sol_rpc_client` bump ([#178](https://github.com/dfinity/sol-rpc-canister/pull/178))
- Migrate dependencies to `solana-sdk` repository ([#55](https://github.com/dfinity/sol-rpc-canister/pull/55))
- Bump `sol_rpc_client` to `v1.0.1` ([#164](https://github.com/dfinity/sol-rpc-canister/pull/164))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here (if there was a 1.0.1 version there should be an entry for 1.0.1 in the changelog)

Comment on lines 13 to 14
- Add build requirements to READMEs and rustdoc ([#169](https://github.com/dfinity/sol-rpc-canister/pull/169))
- Add `Cargo.toml` linting to CI pipeline ([#155](https://github.com/dfinity/sol-rpc-canister/pull/155))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the same reasons as above I would remove this.


### Changed

- Require HTTP outcall base fee ([#185](https://github.com/dfinity/sol-rpc-canister/pull/185))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made in that PR to that crate are not relevant, I would remove it.

### Changed

- Require HTTP outcall base fee ([#185](https://github.com/dfinity/sol-rpc-canister/pull/185))
- Select supported providers based on successful responses ([#183](https://github.com/dfinity/sol-rpc-canister/pull/183))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relevant change to that crate is that there is a new method (rpc_provider_id), should be in the Added section.

- Require HTTP outcall base fee ([#185](https://github.com/dfinity/sol-rpc-canister/pull/185))
- Select supported providers based on successful responses ([#183](https://github.com/dfinity/sol-rpc-canister/pull/183))
- Migrate dependencies to `solana-sdk` repository ([#55](https://github.com/dfinity/sol-rpc-canister/pull/55))
- Improve docs for `InstallArgs` ([#172](https://github.com/dfinity/sol-rpc-canister/pull/172))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove it, this is not relevant regarding existing functionality.

@github-actions github-actions bot changed the title chore: release chore: release v2.0.0 Jul 31, 2025
@github-actions github-actions bot force-pushed the release-plz-2025-07-17T21-43-19Z branch from 28b571d to 862ae24 Compare July 31, 2025 07:18
@github-actions github-actions bot changed the title chore: release v2.0.0 chore: release Jul 31, 2025
@github-actions github-actions bot force-pushed the release-plz-2025-07-17T21-43-19Z branch from 862ae24 to 015f445 Compare July 31, 2025 09:47
@github-actions github-actions bot closed this Jul 31, 2025
@lpahlavi lpahlavi reopened this Jul 31, 2025
@lpahlavi lpahlavi closed this Jul 31, 2025
@lpahlavi
Copy link
Contributor

Thank you for your review and input @gregorydemay!

I hadn't marked the PR as ready for review yet because I was still trying to figure out a way to use release-plz to manage the sol_rpc_canister crate. Unfortunately, I've tried quite a few things and all of them have failed (see the many recent runs of the Publish action on top of quite some local tries). My conclusion is that there is simply no good solution to generate the changelogs and bump the version of the sol_rpc_crate with release-plz without publishing it to crates.io.

This PR was closed in favor of #201 where I addressed your comments.

@lpahlavi lpahlavi mentioned this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants