fix: use correct Token Program for SPL in basic_solana#128
Merged
Conversation
lpahlavi
changed the title
basic_solana SPL functionalitybasic_solana correct Token Program for SPL
lpahlavi
changed the title
basic_solana correct Token Program for SPLbasic_solana
gregorydemay
approved these changes
May 27, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks @lpahlavi for this PR! Some minor comments
gregorydemay
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems that occur when running
basic_solanaagainst Solana Devnet.basic_solana::splfromTokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA(i.e. the legacy Token Program) toTokenzQdBNbLqP5VEhdkAS6EPFLC1PHnBqCXEpPxuEb(i.e. the Token 2022 Program). This broke compatibility with SPL tokens whose token program was the legacy Token Program, e.g. USDC. Instead, this PR fetches the account info for the given mint address and reads the token program ID from theownerfield in the response for all SPL endpoints.getAccountInforesponse, which leads to errors due to this response encoding only supporting responses up to 128 bytes. Therefore, use base64 encoding inbasic_solana.