feat: method to extract durable nonce from account#117
Merged
Conversation
lpahlavi
changed the title
lpahlavi
changed the title
lpahlavi
commented
May 21, 2025
lpahlavi
commented
May 21, 2025
lpahlavi
commented
May 22, 2025
lpahlavi
commented
May 22, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Some high level understanding questions
Contributor
Author
|
@gregorydemay Thanks for having a look at this! I believe I should have answered all of your questions. Let me know what you think. |
gregorydemay
approved these changes
May 27, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR @lpahlavi ! Some minor comments
gregorydemay
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XC-347: Add a helper method in the
sol_rpc_clientcrate to extract the durable nonce value from the response of agetAccountInfoRPC call.