test: use threshold signing in end-to-end tests#114
Merged
Conversation
lpahlavi
force-pushed
the
lpahlavi/XC-317-teddsa-in-e2e-tests
branch
from
59ccc0a to
e80bbef
Compare
lpahlavi
force-pushed
the
lpahlavi/XC-317-teddsa-in-e2e-tests
branch
from
e80bbef to
409a74b
Compare
lpahlavi
changed the base branch from
main
to
lpahlavi/XC-317-client-method-to-sign-transaction
lpahlavi
force-pushed
the
lpahlavi/XC-317-teddsa-in-e2e-tests
branch
from
409a74b to
29d5fe1
Compare
lpahlavi
force-pushed
the
lpahlavi/XC-317-teddsa-in-e2e-tests
branch
from
435cbfa to
be65c11
Compare
lpahlavi
changed the title
ninegua
approved these changes
May 21, 2025
Base automatically changed from
lpahlavi/XC-317-client-method-to-sign-transaction
to
main
May 22, 2025 16:08
lpahlavi
commented
May 23, 2025
Contributor
Author
There was a problem hiding this comment.
There is some minimal refactoring not strictly related to this PR here, but I thought it was not worth its own PR.
gregorydemay
approved these changes
May 23, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks for this PR @lpahlavi ! Only a very minor comment
Comment on lines
-180
to
-181
| SOLANA_SENDER_PRIVATE_KEY_BYTES: ${{ secrets.SOLANA_SENDER_PRIVATE_KEY_BYTES }} | ||
| SOLANA_RECEIVER_PRIVATE_KEY_BYTES: ${{ secrets.SOLANA_RECEIVER_PRIVATE_KEY_BYTES }} |
| } | ||
| // Get the pubkey of the sender, which is derived from the given root Ed25519 key, and the | ||
| // canister ID of the wallet canister (through which all calls are forwarded). | ||
| let (sender_pubkey, _) = |
Contributor
There was a problem hiding this comment.
nit: let's add an assertion that the sender_pubkey is some concrete public key to ensure that this remains stable, e.g.
assert_eq!(sender_pubkey, pubkey!("..."))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(XC-317) Instead of signing the transaction locally in end-to-end tests, sign using threshold EdDSA using the new
sol_rpc_clientmethod.