Conversation
lpahlavi
commented
May 8, 2025
lpahlavi
commented
May 8, 2025
lpahlavi
commented
May 8, 2025
ninegua
approved these changes
May 8, 2025
gregorydemay
reviewed
May 9, 2025
gregorydemay
approved these changes
May 9, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks for this PR @lpahlavi ! Main question for me is whether to put the common code related to SPL in some separate crate if it could be useful to developers using SOL RPC
Comment on lines
+330
to
+332
| .modify_params(|params| { | ||
| params.commitment = Some(CommitmentLevel::Confirmed) | ||
| }) |
Contributor
There was a problem hiding this comment.
nit: I have the impression we could simplify all the tests here by changing icp_client to
fn icp_client(&self) -> SolRpcClient<PocketIcLiveModeRuntime> {
self.setup
.client_live_mode()
.with_default_commitment_level(CommitmentLevel::Confirmed)
.build()
}so that the client uses by default Confirmed and modify_params is then no longer necessary. Better to do that in a separate PR, WDYT?
Contributor
Author
There was a problem hiding this comment.
Agreed, good idea! I will do that in a separate PR.
lpahlavi
deleted the
lpahlavi/XC-325-get-token-account-balance-validator-tests
branch
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(XC-325) Add integration test for
getTokenAccountBalancewith Solana validator.