feat: Add support for `getRecentPrioritizationFees`#92

Merged

gregorydemay merged 44 commits intomainfrom

gdemay/XC-326-get-recent-prioritization-fees

May 14, 2025

Contributor

gregorydemay commented May 5, 2025 •

edited

Loading

Add support for the method getRecentPrioritizationFees.

Supporting this method via HTTPs outcalls offers similar challenges to be able to achieve consensus on the responses as for supporting the method getSlot (#33, #48). Specifically,

Each response to getRecentPrioritizationFees consists of a fast-changing subset of slots, where each slot is associated with a prioritization fee. Responses between nodes may vary because the response contains processed slots and a new processed slot is produced roughly every 400ms.
Similarly to getSlot, we need a heuristic to select deterministically a subset of slots in the response seen by a node that at least two thirds of nodes can agree on with a significant probability, which proceeds as follows:
1. Sort the prioritization fees according to their slot.
2. Agree on the last processed slot. This uses rounding, exactly as for getSlot.
3. Agree on the size of the subset that will contain the prioritization fee of the previously-agreed last processed slot and the remaining fees by decreasing order of slot (higher is more recent).

gregorydemay added 28 commits

May 2, 2025 17:15


          XC-326: base types

1cdf810


          XC-326: logic for GetRecentPrioritizationFees transform

0790f6d


          XC-326: rename maxNumSlots

0237fcc


          XC-326: test normalization

9600f07


          XC-326: main logic

2a119c6


          XC-326: client

48be23a


          XC-326: remove chacha20rng dep

830f102


          Revert "XC-326: remove chacha20rng dep"

3ba6294

This reverts commit 830f102.


          XC-326: remove solana-rpc-client-api dependency because it depends tr…

3f3eb8b

…ansitively on getrandom with default features

cargo tree -i getrandom@0.2.16 -p "sol_rpc_canister"                                                                                                                                                                                                                  101 ↵
getrandom v0.2.16
├── ahash v0.8.11
│   └── solana-feature-set v2.2.0 (https://github.com/dfinity/agave?tag=323039e-js-feature-flag#552a0763)
│       └── solana-version v2.2.0 (https://github.com/dfinity/agave?tag=323039e-js-feature-flag#552a0763)
│           └── solana-rpc-client-api v2.2.0 (https://github.com/dfinity/agave?tag=323039e-js-feature-flag#552a0763)
│               └── sol_rpc_canister v0.1.0 (/Users/greg/git/sol-rpc-canister/canister)


          XC-326: fix cycles cost

58d15d6


          XC-326: failing int test

c2ea711


          XC-326: fix int test

a7ba847


          XC-326: trap when too many accounts

a56a5d7


          XC-326: fix exact cycles cost

fa84e7b


          XC-326: int test with validator

217393e


          XC-326: generate transactions with priority fees

10ff267


          XC-326: fix for non-contiguous range of slots

8896dd1


          Merge branch 'main' into gdemay/XC-326-get-recent-prioritization-fees

5981fe1

# Conflicts:
#	canister/src/main.rs
#	canister/src/rpc_client/mod.rs
#	canister/src/rpc_client/sol_rpc/mod.rs
#	integration_tests/tests/tests.rs
#	libs/client/src/lib.rs
#	libs/client/src/request/mod.rs
#	libs/types/src/lib.rs


          XC-326: rename max_num_slots for max_length

ed33063


          XC-326: add Debug to RequestBuilder


          XC-326: refactor to use json type and add params to client get_recent…

23d2b92

…_prioritization_fees


          XC-326: Rust doc

777ce53


          XC-326: docs

454a9a5


          XC-326: TODO doc

2a7554f


          XC-326: end-to-end test

fc5534f


          XC-326: micro-lamport

b1805c8


          XC-326: remove redundant test since already in Rust docs

e91f8fb


          XC-326: clean-up

2609a63

gregorydemay marked this pull request as ready for review

May 8, 2025 16:48

gregorydemay requested a review from a team as a code owner

May 8, 2025 16:48

gregorydemay added 6 commits

May 12, 2025 11:21


          XC-326: fix indenting

fc041b0


          XC-326: formatting

ccd4c64


          XC-326: simplify Rust doc test

792bba2


          XC-326: typo.

203e830


          XC-326: use Slot type in PrioritizationFee.

6348bf8


          XC-326: serialize_if_ok.

fa4ecf1

gregorydemay commented

View reviewed changes

Contributor Author

gregorydemay left a comment

Thanks for the review @lpahlavi! Should be ready for a 2nd round.

canister/sol_rpc_canister.did Show resolved Hide resolved

canister/src/rpc_client/json/mod.rs Outdated Show resolved Hide resolved

canister/src/rpc_client/mod.rs Show resolved Hide resolved

canister/src/rpc_client/sol_rpc/mod.rs Outdated Show resolved Hide resolved

canister/src/rpc_client/sol_rpc/tests.rs Show resolved Hide resolved

libs/types/src/rpc_client/mod.rs Show resolved Hide resolved

libs/types/src/solana/mod.rs Outdated Show resolved Hide resolved

libs/types/src/rpc_client/mod.rs Show resolved Hide resolved

canister/src/rpc_client/mod.rs Show resolved Hide resolved

canister/src/rpc_client/sol_rpc/mod.rs Outdated Show resolved Hide resolved

gregorydemay added 2 commits

May 12, 2025 15:32


          XC-326: clippy.

e751e1b


          Merge branch 'main' into gdemay/XC-326-get-recent-prioritization-fees

4df3475

# Conflicts:
#	integration_tests/tests/solana_test_validator.rs

lpahlavi reviewed

View reviewed changes

Contributor

lpahlavi left a comment

Thanks for the changes @gregorydemay! Looking good, just one or two small comments from my side.

canister/src/rpc_client/sol_rpc/mod.rs Outdated Show resolved Hide resolved

canister/src/rpc_client/sol_rpc/tests.rs Show resolved Hide resolved

canister/src/rpc_client/sol_rpc/mod.rs Outdated Show resolved Hide resolved

libs/types/src/rpc_client/mod.rs Show resolved Hide resolved

canister/src/rpc_client/sol_rpc/mod.rs Outdated Show resolved Hide resolved

gregorydemay added 3 commits

May 13, 2025 09:35


          XC-326: updated comment for should_normalize_response_with_non_contig…

…uous_slots


          XC-326: rename internal transform method and added docs

b46fa53


          XC-326: clippy

9a131f5

gregorydemay commented

View reviewed changes

Contributor Author

gregorydemay left a comment

Thanks @lpahlavi for the re-review. I think all the points should have been addressed.

canister/src/rpc_client/sol_rpc/tests.rs Show resolved Hide resolved

canister/src/rpc_client/sol_rpc/mod.rs Outdated Show resolved Hide resolved

canister/src/rpc_client/sol_rpc/mod.rs Outdated Show resolved Hide resolved

lpahlavi reviewed

View reviewed changes

Contributor

lpahlavi left a comment

Thanks for the updates @gregorydemay! Just an understanding question and a very minor comment from my side.

gregorydemay added 2 commits

May 13, 2025 16:17


          XC-326: serialize to tuple


          XC-326: use canonicalize_response

0ad144a

lpahlavi approved these changes

View reviewed changes

Contributor

lpahlavi left a comment

Thanks again for the PR @gregorydemay LGTM!

ninegua approved these changes

View reviewed changes

Member

ninegua left a comment

LGTM!

canister/src/rpc_client/json/mod.rs Show resolved Hide resolved

gregorydemay merged commit 3a70730 into main

12 checks passed

gregorydemay deleted the gdemay/XC-326-get-recent-prioritization-fees branch

May 14, 2025 07:21

This was referenced May 19, 2025

feat: Candid NonZeroU8 #108

Merged

docs: table for supported methods and known limitations #116

Merged

gregorydemay added a commit that referenced this pull request


          docs: table for supported methods and known limitations (#116)

8c20f91

Follow-up on #92 and #96 to add a detailed table explaining the
supported methods and their current limitations.

gregorydemay added a commit that referenced this pull request


          feat: Candid NonZeroU8 (#108)

3bf6815

Follow-up on #92 to add a Candid wrapper type around
[`std::num::NonZeroU8`](https://doc.rust-lang.org/std/num/type.NonZeroU8.html)
to be used in `GetRecentPrioritizationFeesRpcConfig` so that

1. A zero value will fail deserialization, but otherwise Candid
encoding/decoding is the same as for a `u8`.
2. The default value of `100` for the number of returned priority fees
(unless specified otherwise in
`GetRecentPrioritizationFeesRpcConfig::max_length`) is specified in the
`sol_rpc_types` crate.

github-actions bot mentioned this pull request

chore: release v0.2.0 #131

Merged

gregorydemay added a commit that referenced this pull request


          chore: release v0.2.0 (#131)

11c9802

## 🤖 New release

* `sol_rpc_canister`: 0.2.0

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.2.0] - 2025-05-27

### Added

- Add client method to sign a transaction
([#113](#113))
- Add Chainstack RPC provider
([#118](#118))
- Add support for `getSignaturesForAddress`
([#106](#106))
- Add support for `getSignatureStatuses` RPC method
([#96](#96))
- Add support for `getTokenAccountBalance` RPC method
([#90](#90))
- Add support for `getTransaction` RPC method
([#68](#68))
- Add `getBlock` RPC method
([#53](#53))
- Add `sendTransaction` RPC method
([#59](#59))
- Add NOTICE to Apache license
([#60](#60))
- Add `getAccountInfo` RPC method
([#49](#49))
- Add metrics
([#41](#41))
- Add logging crate
([#13](#13))
- Add support for override providers
([#12](#12))

### Changed

- Bump version to 0.2
- Candid NonZeroU8
([#108](#108))
- Add `RoundingError` to `sol_rpc_types`
([#105](#105))
- Use secure primitive types for `Pubkey`, `Signature` and `Hash`
([#98](#98))
- Add support for `getRecentPrioritizationFees`
([#92](#92))
- Simplify API keys provisioning script
([#89](#89))
- Release v0.1.0
([#88](#88))
- Use `canlog_derive` and `canlog` from crates.io
([#84](#84))
- Release pipeline
([#4](#4))
- Clean-up TODOs
([#81](#81))
- Support method `getBalance`
([#74](#74))
- Remove http_types module and use external ic-http-types crate
([#73](#73))
- Rename some enum variants to camel case when serializing
([#72](#72))
- Use constant size JSON-RPC request ID
([#62](#62))
- Use method from JSON-RPC request for metric
([#61](#61))
- Cycles cost
([#52](#52))
- Client builder
([#54](#54))
- Round result from `getSlot` RPC method
([#48](#48))
- Use `canhttp` `multi` feature
([#46](#46))
- Implement a method for making generic RPC request
([#39](#39))
- Implement getSlot RPC method
([#33](#33))
- Add some tested RPC providers for Solana Mainnet and Devnet
([#15](#15))
- Streamline providers
([#32](#32))
- Update rust toolchain to 1.85
([#21](#21))
- Remove unnecessary Storable implementations
([#14](#14))
- Add support for API keys
([#10](#10))
- Hard-code SOL RPC providers
([#9](#9))
- Reproducible build
([#3](#3))
- Initial cargo workspace and build pipeline
([#2](#2))

### Fixed

- Missing `TraceHttp` logs
([#129](#129))
- End-to-end tests for `sendTransaction`
([#104](#104))
- Unit test for `getRecentPrioritizationFees` parameters serialization
([#107](#107))
- Integration test for `verifyApiKey`
([#82](#82))
- Set `maxSupportedTransactionVersion` to zero for end-to-end tests
([#85](#85))
- API keys ([#58](#58))
- End-to-end tests
([#45](#45))
- Correct Solana cluster for dRPC and Helius providers
([#47](#47))
- E2e test with Solana test validator
([#20](#20))
- Create test canister on ICP mainnet
([#8](#8))

### Removed

- Remove default/non-default providers
([#122](#122))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: gregorydemay <gregory.demay@dfinity.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot mentioned this pull request

chore: release v1.0.0 #146

Merged

gregorydemay added a commit that referenced this pull request


          chore: release v1.0.0 (#146)

e3e416a

## 🤖 New release

* `sol_rpc_canister`: 1.0.0

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [1.0.0] - 2025-06-12

### Added

- Add support for `transactionDetails=accounts`
([#139](#139))
- Add support for `rewards` parameter for `getBlock`
([#135](#135))
- Add helper methods for request builders
([#136](#136))
- Add client method to sign a transaction
([#113](#113))
- Add Chainstack RPC provider
([#118](#118))
- Add support for `getSignaturesForAddress`
([#106](#106))
- Add support for `getSignatureStatuses` RPC method
([#96](#96))
- Add support for `getTokenAccountBalance` RPC method
([#90](#90))
- Add support for `getTransaction` RPC method
([#68](#68))
- Add `getBlock` RPC method
([#53](#53))
- Add `sendTransaction` RPC method
([#59](#59))
- Add NOTICE to Apache license
([#60](#60))
- Add `getAccountInfo` RPC method
([#49](#49))
- Add metrics
([#41](#41))
- Add logging crate
([#13](#13))
- Add support for override providers
([#12](#12))

### Changed

- Bump to 1.0.0
- Inline request parameters `is_default_config` methods
([#138](#138))
- Release v0.2.0
([#131](#131))
- Bump version and use a release notes template
([#130](#130))
- Candid NonZeroU8
([#108](#108))
- Add `RoundingError` to `sol_rpc_types`
([#105](#105))
- Use secure primitive types for `Pubkey`, `Signature` and `Hash`
([#98](#98))
- Add support for `getRecentPrioritizationFees`
([#92](#92))
- Simplify API keys provisioning script
([#89](#89))
- Release v0.1.0
([#88](#88))
- Use `canlog_derive` and `canlog` from crates.io
([#84](#84))
- Release pipeline
([#4](#4))
- Clean-up TODOs
([#81](#81))
- Support method `getBalance`
([#74](#74))
- Remove http_types module and use external ic-http-types crate
([#73](#73))
- Rename some enum variants to camel case when serializing
([#72](#72))
- Use constant size JSON-RPC request ID
([#62](#62))
- Use method from JSON-RPC request for metric
([#61](#61))
- Cycles cost
([#52](#52))
- Client builder
([#54](#54))
- Round result from `getSlot` RPC method
([#48](#48))
- Use `canhttp` `multi` feature
([#46](#46))
- Implement a method for making generic RPC request
([#39](#39))
- Implement getSlot RPC method
([#33](#33))
- Add some tested RPC providers for Solana Mainnet and Devnet
([#15](#15))
- Streamline providers
([#32](#32))
- Update rust toolchain to 1.85
([#21](#21))
- Remove unnecessary Storable implementations
([#14](#14))
- Add support for API keys
([#10](#10))
- Hard-code SOL RPC providers
([#9](#9))
- Reproducible build
([#3](#3))
- Initial cargo workspace and build pipeline
([#2](#2))

### Fixed

- Missing `TraceHttp` logs
([#129](#129))
- End-to-end tests for `sendTransaction`
([#104](#104))
- Unit test for `getRecentPrioritizationFees` parameters serialization
([#107](#107))
- Integration test for `verifyApiKey`
([#82](#82))
- Set `maxSupportedTransactionVersion` to zero for end-to-end tests
([#85](#85))
- API keys ([#58](#58))
- End-to-end tests
([#45](#45))
- Correct Solana cluster for dRPC and Helius providers
([#47](#47))
- E2e test with Solana test validator
([#20](#20))
- Create test canister on ICP mainnet
([#8](#8))

### Removed

- Remove default/non-default providers
([#122](#122))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: gregorydemay <gregory.demay@dfinity.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: gregorydemay <112856886+gregorydemay@users.noreply.github.com>

github-actions bot mentioned this pull request

chore: release #189

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet