Conversation
lpahlavi
changed the title
basic_solana instructionsbasic_solana instructions
lpahlavi
force-pushed
the
lpahlavi/XC-355-address-basic-solana-feedback
branch
from
99f82fd to
f402038
Compare
lpahlavi
changed the title
basic_solana instructionsbasic_solana locally and on mainnet
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks for improving the example @lpahlavi ! Could you also add Kristofer as a reviewer?
|
Thanks a lot for the review @gregorydemay! I've added @kristoferlund as a reviewer. I still need to dig into what might be causing your local deployment issues, but your other comments should have been addressed. |
| "canisters": { | ||
| "basic_solana": { | ||
| "candid": "basic_solana.did", | ||
| "candid": "../../../canister/sol_rpc_canister.did", |
There was a problem hiding this comment.
that seems incorrect, no? this should be basic_solana.did I think
There was a problem hiding this comment.
Good catch! Curious why this didn't seem to be a problem when deploying to Mainnet. I wonder if it's actually unneeded? WDYT?
There was a problem hiding this comment.
Curious why this didn't seem to be a problem when deploying to Mainnet. I wonder if it's actually unneeded? WDYT?
Good question, I would have guessed that it's needed to encode candid payload. I would currently leave it as is.
2 participants
(XC-335) This PR adds support for running the
basic_solanaexamples both locally and on mainnet. Documentation is updated in theREADME.mdand two separate setups are added fordfxinlocalandmainnet.