Skip to content

docs: improvements to SOL RPC docs#158

Merged
letmejustputthishere merged 17 commits intomainfrom
feature/docs-improvements
Jul 23, 2025
Merged

docs: improvements to SOL RPC docs#158
letmejustputthishere merged 17 commits intomainfrom
feature/docs-improvements

Conversation

@letmejustputthishere
Copy link
Contributor

@letmejustputthishere letmejustputthishere commented Jun 27, 2025

This PR implements improvements and fixes for the documentation of the SOL RPC canister example.

@letmejustputthishere letmejustputthishere requested a review from a team as a code owner June 27, 2025 07:08
@letmejustputthishere letmejustputthishere changed the title Feature/docs-improvements fix: docs & candid Jun 27, 2025
@letmejustputthishere letmejustputthishere changed the title fix: docs & candid fix: docs & candid comments Jun 27, 2025
Copy link
Contributor

@lpahlavi lpahlavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the improvements @letmejustputthishere! Super thankful to have your feedback, I think it definitely helps a lot to have the perspective of someone outside of the SOL RPC dev team for this.

Copy link
Contributor

@lpahlavi lpahlavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the improvements @letmejustputthishere! I believe I should have answered/addressed all of your comments. Could you please:

  • incorporate the latest changes in main, and
  • add a commit message (top-level comment) referencing XC-405?

🙏

@letmejustputthishere letmejustputthishere force-pushed the feature/docs-improvements branch from 79c7f39 to cc932ec Compare July 11, 2025 08:44
@letmejustputthishere letmejustputthishere force-pushed the feature/docs-improvements branch from cc932ec to 97c747e Compare July 11, 2025 08:48
@letmejustputthishere
Copy link
Contributor Author

@lpahlavi this should be ready to review 🚀

Copy link
Contributor

@lpahlavi lpahlavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the improvements @letmejustputthishere! Just a couple tiny nits from my side.

@letmejustputthishere
Copy link
Contributor Author

@lpahlavi thanks for the feedback! i implemented the changes, let me know if you find something else :)

Copy link
Contributor

@lpahlavi lpahlavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the improvements @letmejustputthishere! Just one tiny comment from my side, otherwise LGTM!

@lpahlavi lpahlavi changed the title fix: docs & candid comments fix: docs and candid comments Jul 22, 2025
@lpahlavi lpahlavi changed the title fix: docs and candid comments docs: improve docs and Candid comments Jul 22, 2025
@lpahlavi lpahlavi changed the title docs: improve docs and Candid comments docs: improvements to SOL RPC docs Jul 22, 2025
@letmejustputthishere letmejustputthishere merged commit 7ed9669 into main Jul 23, 2025
22 of 23 checks passed
@letmejustputthishere letmejustputthishere deleted the feature/docs-improvements branch July 23, 2025 12:46
@github-actions github-actions bot mentioned this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants