docs: improvements to SOL RPC docs#158
Conversation
lpahlavi
left a comment
There was a problem hiding this comment.
Thanks a lot for the improvements @letmejustputthishere! Super thankful to have your feedback, I think it definitely helps a lot to have the perspective of someone outside of the SOL RPC dev team for this.
lpahlavi
left a comment
There was a problem hiding this comment.
Thanks a lot for the improvements @letmejustputthishere! I believe I should have answered/addressed all of your comments. Could you please:
- incorporate the latest changes in
main, and - add a commit message (top-level comment) referencing XC-405?
🙏
…install in dfx.json for sol_rpc
Co-authored-by: Louis Pahlavi <louis.pahlavi@gmail.com>
79c7f39 to
cc932ec
Compare
cc932ec to
97c747e
Compare
|
@lpahlavi this should be ready to review 🚀 |
lpahlavi
left a comment
There was a problem hiding this comment.
Thanks a lot for the improvements @letmejustputthishere! Just a couple tiny nits from my side.
|
@lpahlavi thanks for the feedback! i implemented the changes, let me know if you find something else :) |
lpahlavi
left a comment
There was a problem hiding this comment.
Thanks a lot for the improvements @letmejustputthishere! Just one tiny comment from my side, otherwise LGTM!
This PR implements improvements and fixes for the documentation of the SOL RPC canister example.