fix: missing cmake and protobuf for windows build #4816

vlascik · 2025-09-25T10:05:27Z

Pull Request Description

Fix: install missing cmake and protobuf to docker image for windows build, to align with other platforms.

Build is broken otherwise.

Signed-off-by: V. Lascik <vlascik@users.noreply.github.com>

alexhancock · 2025-09-25T13:17:39Z

Justfile

    else
        echo "Building Windows executable using Docker through PowerShell..."
-        powershell.exe -Command "docker volume create goose-windows-cache; docker run --rm -v ${PWD}:/usr/src/myapp -v goose-windows-cache:/usr/local/cargo/registry -w /usr/src/myapp rust:latest sh -c 'rustup target add x86_64-pc-windows-gnu && apt-get update && apt-get install -y mingw-w64 && cargo build --release --target x86_64-pc-windows-gnu && GCC_DIR=\$(ls -d /usr/lib/gcc/x86_64-w64-mingw32/*/ | head -n 1) && cp \$GCC_DIR/libstdc++-6.dll /usr/src/myapp/target/x86_64-pc-windows-gnu/release/ && cp \$GCC_DIR/libgcc_s_seh-1.dll /usr/src/myapp/target/x86_64-pc-windows-gnu/release/ && cp /usr/x86_64-w64-mingw32/lib/libwinpthread-1.dll /usr/src/myapp/target/x86_64-pc-windows-gnu/release/'"
+        powershell.exe -Command "docker volume create goose-windows-cache; docker run --rm -v ${PWD}:/usr/src/myapp -v goose-windows-cache:/usr/local/cargo/registry -w /usr/src/myapp rust:latest sh -c 'rustup target add x86_64-pc-windows-gnu && apt-get update && apt-get install -y mingw-w64 protobuf-compiler cmake && export CC_x86_64_pc_windows_gnu=x86_64-w64-mingw32-gcc && export CXX_x86_64_pc_windows_gnu=x86_64-w64-mingw32-g++ && export AR_x86_64_pc_windows_gnu=x86_64-w64-mingw32-ar && export CARGO_TARGET_X86_64_PC_WINDOWS_GNU_LINKER=x86_64-w64-mingw32-gcc && export PKG_CONFIG_ALLOW_CROSS=1 && export PROTOC=/usr/bin/protoc && export PATH=/usr/bin:\$PATH && protoc --version && cargo build --release --target x86_64-pc-windows-gnu && GCC_DIR=\$(ls -d /usr/lib/gcc/x86_64-w64-mingw32/*/ | head -n 1) && cp \$GCC_DIR/libstdc++-6.dll /usr/src/myapp/target/x86_64-pc-windows-gnu/release/ && cp \$GCC_DIR/libgcc_s_seh-1.dll /usr/src/myapp/target/x86_64-pc-windows-gnu/release/ && cp /usr/x86_64-w64-mingw32/lib/libwinpthread-1.dll /usr/src/myapp/target/x86_64-pc-windows-gnu/release/'"


can we take this opportunity to break this out to different lines so it's more readable what's going on here?

also, a comment explaining what each thing added is for would help a lot with review

So the original problem was that the windows build command apt-get install -y mingw-w64 protobuf-compiler cmake... was missing cmake and protobuf-compiler when started from powershell, and not sh. Apparently someone added it to sh, but forgot to put it to the powershell part, so if the build was started from powershell, it didn't work.

I extracted the command to a variable, this way it's in one place and people won't have to remember to make the changes twice.

I see. Thanks for the clarification. Looks like there is a conflict to work out

I will see if I can run a full build of this before merge to verify everything works well for our automated windows builds.

block#4795)

…rs (block#4124) Signed-off-by: sings-to-bees-on-wednesdays <222684290+sings-to-bees-on-wednesdays@users.noreply.github.com> Co-authored-by: Jack Amadeo <jackamadeo@block.xyz> Co-authored-by: Jack Amadeo <jackamadeo@squareup.com>

Co-authored-by: tlongwell-block <109685178+tlongwell-block@users.noreply.github.com> Co-authored-by: Tyler Longwell <tlongwell@squareup.com>

…rs and compact" (block#4820)

…scription (block#4824)

Signed-off-by: Angela Ning <aning@squareup.com>

Co-authored-by: Douwe Osinga <douwe@squareup.com>

Co-authored-by: taniashiba <126204004+taniashiba@users.noreply.github.com>

Co-authored-by: Tania Chakraborty <tchakraborty@block.xyz> Co-authored-by: Angie Jones <jones.angie@gmail.com>

…ck#4858)

…error (block#4621) Signed-off-by: jalateras <jima@comware.com.au>

Co-authored-by: Douwe Osinga <douwe@squareup.com>

Signed-off-by: sings-to-bees-on-wednesdays <222684290+sings-to-bees-on-wednesdays@users.noreply.github.com> main was broken. this seems important

Signed-off-by: Evanfeenstra <evanfeenstra@gmail.com>

…block#4847)

Signed-off-by: AdemolaAri <ademola.ari@gmail.com>

… (block#4859) Signed-off-by: demetrio108 <demetrio108@protonmail.com>

Signed-off-by: jalateras <jima@comware.com.au> Co-authored-by: Ebony Louis <55366651+EbonyLouis@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Jack Amadeo <jackamadeo@squareup.com>

…th sh and pwsh contexts Signed-off-by: V. Lascik <vlascik@users.noreply.github.com>

…es (block#4464) Signed-off-by: Matt Donovan <mattddonovan@protonmail.com> Co-authored-by: Matt Donovan <mattddonovan@protonmail.com>

Co-authored-by: Douwe Osinga <douwe@squareup.com>

Signed-off-by: V. Lascik <vlascik@users.noreply.github.com>

…th sh and pwsh contexts Signed-off-by: V. Lascik <vlascik@users.noreply.github.com>

Signed-off-by: V. Lascik <vlascik@users.noreply.github.com>

vlascik · 2025-09-30T15:34:08Z

So, there was a different problem in mod.rs file, I tried to be clever with the branching of the fixes, but someone else fixed it in the meantime, and it seems I messed this branch up royally.

I'll close this and post the fix in a new PR, I'm too tired to try to unwind this mess. Sorry 😄.

alexhancock · 2025-09-30T15:38:32Z

No problem. Ping me on the new PR

vlascik added 2 commits September 25, 2025 12:01

fix: missing cmake for windows build

3495d84

Signed-off-by: V. Lascik <vlascik@users.noreply.github.com>

fix: goose-mcp build on windows

d41ac75

Signed-off-by: V. Lascik <vlascik@users.noreply.github.com>

alexhancock reviewed Sep 25, 2025

View reviewed changes

zanesq and others added 27 commits September 25, 2025 07:08

cleanup: remove unused link preview and goose response form components (

94cf5c8

block#4795)

test: add test coverage for Tools Inspector (block#4700)

ca3d69b

Co-authored-by: tlongwell-block <109685178+tlongwell-block@users.noreply.github.com> Co-authored-by: Tyler Longwell <tlongwell@squareup.com>

Revert "fix(compaction): try to catch more context limit exceeded ero…

2f11d8d

…rs and compact" (block#4820)

fix: a few things with the mcp snapshot test (block#4818)

917e179

fix: remove nested double quotes in windows automation_script tool de…

b7604e0

…scription (block#4824)

fix chat button alignment and spacing for attachments (block#4794)

f0ab2c5

blog post on subagents vs subrecipes (block#4829)

4acd7c2

fix: pricing integration test (block#4837)

f5877a9

chore: turn clippy on for test code (block#4817)

757ceb6

add automation for marking and closing stale PRs (block#4826)

d0b875e

fix: keep one goosed client per BrowswerWindow (block#4805)

4e786db

fix: linux builds: use gcc 10 in Linux builds (block#4841)

945c783

chore: fix all warnings in test compilation (block#4827)

5ba4143

Update video link in README.md to lowercase goose (block#4846)

3fd807e

remove only-pr-labels (block#4842)

7fac1f3

Signed-off-by: Angela Ning <aning@squareup.com>

Docs: Add link to Plug & Play video for Reddit MCP (block#4852)

832cb04

Fix: Token count UI doesn't re-render if it's open. (block#4822)

7451761

Update databricks flash model (block#4836)

d0aa14a

Session manager (block#4648)

dc29288

Co-authored-by: Douwe Osinga <douwe@squareup.com>

Add Hacktoberfest Guides (block#4830)

5999b78

Co-authored-by: taniashiba <126204004+taniashiba@users.noreply.github.com>

docs: goose x Hacktoberfest 2025 Blog (block#4855)

8662e0b

Co-authored-by: Tania Chakraborty <tchakraborty@block.xyz> Co-authored-by: Angie Jones <jones.angie@gmail.com>

fix: delete some flaky and not-useful tests (block#4861)

4af47fe

can tell the system what shell it is using (block#4807)

1e4d874

new subrecipe blog post banner (block#4862)

28113b1

docs: remove recipe generator link from next to extension search (blo…

bb1b73d

…ck#4858)

lowercase g in goose (block#4832)

2032c70

jalateras and others added 15 commits September 29, 2025 10:08

Fix block#4612: Return non-zero exit code when CLI session ends with …

3844209

…error (block#4621) Signed-off-by: jalateras <jima@comware.com.au>

Internal MCP Crate Cleanup (block#4800)

146cf31

remove 2 redundant comments and one that lies (block#4866)

2cfef01

Co-authored-by: Douwe Osinga <douwe@squareup.com>

Revert "Internal MCP Crate Cleanup (block#4800)" (block#4883)

b9ba8dc

fix(token_counter): fix panic with GitHub Copilot (block#4632)

509fcac

Signed-off-by: sings-to-bees-on-wednesdays <222684290+sings-to-bees-on-wednesdays@users.noreply.github.com> main was broken. this seems important

Cli web auth token (block#4456)

41d32c0

Signed-off-by: Evanfeenstra <evanfeenstra@gmail.com>

make agent manager singleton (block#4880)

1c42430

docs: new multi-model section with autopilot topic (block#4864)

976e663

docs: rename sub-recipe to subrecipe (block#4886)

2bd18a7

alexhancock/mcp-crate-cleanup (block#4885)

cb0eca9

Add filtering for agentVisible: false messages on streaming providers (…

1a92111

…block#4847)

add new prompt to get all available tutorials (block#4802)

07d4506

Signed-off-by: AdemolaAri <ademola.ari@gmail.com>

fix: path is duplicated on tool calls causing them to fail (block#4658)…

5c9be9a

… (block#4859) Signed-off-by: demetrio108 <demetrio108@protonmail.com>

extract windows build command to a string, run the same command in bo…

8e186cf

…th sh and pwsh contexts Signed-off-by: V. Lascik <vlascik@users.noreply.github.com>

DOsinga assigned alexhancock Sep 30, 2025

thebristolsound and others added 2 commits September 30, 2025 08:58

fix: Windows prompt cursor positioning issue with ANSI escape sequenc…

af40917

…es (block#4464) Signed-off-by: Matt Donovan <mattddonovan@protonmail.com> Co-authored-by: Matt Donovan <mattddonovan@protonmail.com>

Allow better concurrent access (block#4896)

4d17c98

Co-authored-by: Douwe Osinga <douwe@squareup.com>

alexhancock approved these changes Sep 30, 2025

View reviewed changes

exitcode0 and others added 5 commits September 30, 2025 10:12

feat(cli): add path & limit to session list command (block#4878)

114a3b3

fix: missing cmake for windows build

26fb56f

Signed-off-by: V. Lascik <vlascik@users.noreply.github.com>

extract windows build command to a string, run the same command in bo…

5f6e646

…th sh and pwsh contexts Signed-off-by: V. Lascik <vlascik@users.noreply.github.com>

Merge remote-tracking branch 'origin/fix-missing-cmake-on-windows'

57a5d87

undo changes in mod.rs

8d69bd5

Signed-off-by: V. Lascik <vlascik@users.noreply.github.com>

vlascik requested a review from a team as a code owner September 30, 2025 15:29

vlascik closed this Sep 30, 2025

vlascik mentioned this pull request Oct 6, 2025

fix: missing cmake and protobuf for windows build, deduplicate sh/pws… #5028

Merged

9 tasks

vlascik deleted the fix-missing-cmake-on-windows branch October 23, 2025 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: missing cmake and protobuf for windows build #4816

fix: missing cmake and protobuf for windows build #4816

Uh oh!

vlascik commented Sep 25, 2025

Uh oh!

alexhancock Sep 25, 2025

Uh oh!

vlascik Sep 30, 2025

Uh oh!

alexhancock Sep 30, 2025

Uh oh!

vlascik commented Sep 30, 2025

Uh oh!

alexhancock commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

fix: missing cmake and protobuf for windows build #4816

fix: missing cmake and protobuf for windows build #4816

Uh oh!

Conversation

vlascik commented Sep 25, 2025

Pull Request Description

Uh oh!

alexhancock Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

vlascik Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

alexhancock Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

vlascik commented Sep 30, 2025

Uh oh!

alexhancock commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants