fix: path is duplicated on tool calls causing them to fail (#4658) #4859

demetrio108 · 2025-09-26T19:15:30Z

There is an issue opened

#4658
Path is duplicated on tool calls causing them to fail

What happens is when LLM calls text_editor in diff mode it passes
path: /a/b/c/base/src/file.go
in diff there is path: base/src/file.go

Inside mpatch they are merged and produce
path: /a/b/c/base/src/base/src/file.go

This path doesn't exist and tool fails.

Maybe it's an error from LLM side, that it calls tool incorrectly. But I tried several and it's a common issue.

So I propose to remove overlapping part from base_dir before sending to mpatch. I tested fix in Linux and it works good.

Signed-off-by: demetrio108 <demetrio108@protonmail.com>

michaelneale · 2025-09-29T00:45:28Z

thanks @demetrio108 cc @tlongwell-block wonder if this was impacting well formed diff problem you mentioned?

michaelneale · 2025-09-29T01:11:11Z

@demetrio108 will need to run ./scripts/clippy-lint.sh (or ask goose to sort it out!)

crates/goose-mcp/src/developer/text_editor.rs

DOsinga · 2025-09-29T13:35:47Z

crates/goose-mcp/src/developer/text_editor.rs

+        let adjusted_components = base_components[..base_components.len() - max_k].to_vec();
+        PathBuf::from_iter(adjusted_components)
+    } else {
+        base_dir.to_path_buf()


should this change the type too? if so adjust the name

You mean Path to PathBuf? It's impossible to return Path. I'm not sure which name change you mean

crates/goose-mcp/src/developer/text_editor.rs

DOsinga · 2025-09-29T13:39:35Z

crates/goose-mcp/src/developer/text_editor.rs


    // Apply patch with fuzzy matching (70% similarity threshold)
-    let success = apply_patch(patch, base_dir, false, 0.7).map_err(|e| match e {
+    let success = apply_patch(patch, &adjusted_base_dir, false, 0.7).map_err(|e| match e {


I am not sure I have enough context here, but is this right? should we use the adjusted base here or should we have adjusted the patch file_path?

Inside the patch there is valid path relative to current goose working directory. Base directory is passed wrong by LLM

ah, thanks, that's helpful

Signed-off-by: demetrio108 <demetrio108@protonmail.com>

demetrio108 · 2025-09-29T19:24:38Z

@demetrio108 will need to run ./scripts/clippy-lint.sh (or ask goose to sort it

@michaelneale done

DOsinga

fix the n2 and let's merge!

demetrio108 · 2025-09-29T20:19:31Z

@DOsinga I don't understand, what n2?

michaelneale · 2025-09-29T21:36:40Z

@demetrio108 I think @DOsinga means the O n squared thing here #4859 (comment) - which looks like you changed some code for?

demetrio108 · 2025-09-29T22:26:41Z

There's KMP algorithm with O(m+n) complexity, but it's an overkill in current case and it's not elegant

…-unification * 'main' of github.com:block/goose: (24 commits) feat(cli): add `path` & `limit` to `session list` command (#4878) Allow better concurrent access (#4896) fix: Windows prompt cursor positioning issue with ANSI escape sequences (#4464) Fix: LiteLLM API key field not showing in UI configuration (#4105) fix: path is duplicated on tool calls causing them to fail (#4658) (#4859) add new prompt to get all available tutorials (#4802) Add filtering for agentVisible: false messages on streaming providers (#4847) alexhancock/mcp-crate-cleanup (#4885) docs: rename sub-recipe to subrecipe (#4886) docs: new multi-model section with autopilot topic (#4864) make agent manager singleton (#4880) Cli web auth token (#4456) fix(token_counter): fix panic with GitHub Copilot (#4632) Revert "Internal MCP Crate Cleanup (#4800)" (#4883) remove 2 redundant comments and one that lies (#4866) Internal MCP Crate Cleanup (#4800) Fix #4612: Return non-zero exit code when CLI session ends with error (#4621) Dead code cleanup (#4873) fix: restoring test data and correcting name (#4875) Add .goosehints file to enforce lowercase branding in documentation (#4870) ...

* remove only-pr-labels (block#4842) Signed-off-by: Angela Ning <aning@squareup.com> * Docs: Add link to Plug & Play video for Reddit MCP (block#4852) * Fix: Token count UI doesn't re-render if it's open. (block#4822) * Update databricks flash model (block#4836) * Session manager (block#4648) Co-authored-by: Douwe Osinga <douwe@squareup.com> * Add Hacktoberfest Guides (block#4830) Co-authored-by: taniashiba <126204004+taniashiba@users.noreply.github.com> * docs: goose x Hacktoberfest 2025 Blog (block#4855) Co-authored-by: Tania Chakraborty <tchakraborty@block.xyz> Co-authored-by: Angie Jones <jones.angie@gmail.com> * fix: delete some flaky and not-useful tests (block#4861) * can tell the system what shell it is using (block#4807) * new subrecipe blog post banner (block#4862) * docs: remove recipe generator link from next to extension search (block#4858) * lowercase g in goose (block#4832) * doc: file parameter recipe update (block#4594) * Fiie input recipe ref doc (block#4869) * Add .goosehints file to enforce lowercase branding in documentation (block#4870) Co-authored-by: Angie Jones <jones.angie@gmail.com> * fix: restoring test data and correcting name (block#4875) * Dead code cleanup (block#4873) Co-authored-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: Michael Neale <michael.neale@gmail.com> * Fix block#4612: Return non-zero exit code when CLI session ends with error (block#4621) Signed-off-by: jalateras <jima@comware.com.au> * Internal MCP Crate Cleanup (block#4800) * remove 2 redundant comments and one that lies (block#4866) Co-authored-by: Douwe Osinga <douwe@squareup.com> * Revert "Internal MCP Crate Cleanup (block#4800)" (block#4883) * fix(token_counter): fix panic with GitHub Copilot (block#4632) Signed-off-by: sings-to-bees-on-wednesdays <222684290+sings-to-bees-on-wednesdays@users.noreply.github.com> main was broken. this seems important * Cli web auth token (block#4456) Signed-off-by: Evanfeenstra <evanfeenstra@gmail.com> * make agent manager singleton (block#4880) * docs: new multi-model section with autopilot topic (block#4864) * docs: rename sub-recipe to subrecipe (block#4886) * alexhancock/mcp-crate-cleanup (block#4885) * Temporary workaround for mcp server * Add filtering for agentVisible: false messages on streaming providers (block#4847) * add new prompt to get all available tutorials (block#4802) Signed-off-by: AdemolaAri <ademola.ari@gmail.com> * Fix for auth in extension, fix for stale keychain * fix: path is duplicated on tool calls causing them to fail (block#4658) (block#4859) Signed-off-by: demetrio108 <demetrio108@protonmail.com> * Fix: LiteLLM API key field not showing in UI configuration (block#4105) Signed-off-by: jalateras <jima@comware.com.au> Co-authored-by: Ebony Louis <55366651+EbonyLouis@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Jack Amadeo <jackamadeo@squareup.com> * fix: Windows prompt cursor positioning issue with ANSI escape sequences (block#4464) Signed-off-by: Matt Donovan <mattddonovan@protonmail.com> Co-authored-by: Matt Donovan <mattddonovan@protonmail.com> * Allow better concurrent access (block#4896) Co-authored-by: Douwe Osinga <douwe@squareup.com> * feat(cli): add `path` & `limit` to `session list` command (block#4878) * Added CMD+T keyboard shortcut that takes you to the Home tab (block#4541) Signed-off-by: Guillaume Simard <2000390+GuiSim@users.noreply.github.com> --------- Signed-off-by: Angela Ning <aning@squareup.com> Signed-off-by: jalateras <jima@comware.com.au> Signed-off-by: Evanfeenstra <evanfeenstra@gmail.com> Signed-off-by: AdemolaAri <ademola.ari@gmail.com> Signed-off-by: demetrio108 <demetrio108@protonmail.com> Signed-off-by: Matt Donovan <mattddonovan@protonmail.com> Signed-off-by: Guillaume Simard <2000390+GuiSim@users.noreply.github.com> Co-authored-by: Angela Ning <32008323+angelahning@users.noreply.github.com> Co-authored-by: Emma Youndtsmith <90283317+emma-squared@users.noreply.github.com> Co-authored-by: David Katz <dkatz@squareup.com> Co-authored-by: Douwe Osinga <douwe@block.xyz> Co-authored-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: Ebony Louis <55366651+EbonyLouis@users.noreply.github.com> Co-authored-by: taniashiba <126204004+taniashiba@users.noreply.github.com> Co-authored-by: taniandjerry <126204004+taniandjerry@users.noreply.github.com> Co-authored-by: Tania Chakraborty <tchakraborty@block.xyz> Co-authored-by: Angie Jones <jones.angie@gmail.com> Co-authored-by: Jack Amadeo <jackamadeo@block.xyz> Co-authored-by: Michael Neale <michael.neale@gmail.com> Co-authored-by: w. ian douglas <ian.douglas@iandouglas.com> Co-authored-by: Alex Hancock <alexhancock@block.xyz> Co-authored-by: Jarrod Sibbison <72240382+jsibbison-square@users.noreply.github.com> Co-authored-by: Rizel Scarlett <rizel@squareup.com> Co-authored-by: Jim Alateras <jima@comware.com.au> Co-authored-by: sings-to-bees-on-wednesdays <222684290+sings-to-bees-on-wednesdays@users.noreply.github.com> Co-authored-by: Evan Feenstra <evanfeenstra@gmail.com> Co-authored-by: Yingjie He <yingjiehe@squareup.com> Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com> Co-authored-by: Ademola Arigbabuwo <49918815+AdemolaAri@users.noreply.github.com> Co-authored-by: Demetrio ⚡️ <35406575+demetrio108@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Jack Amadeo <jackamadeo@squareup.com> Co-authored-by: Matt Donovan <mattddonovan@proton.me> Co-authored-by: Matt Donovan <mattddonovan@protonmail.com> Co-authored-by: Robert Mcgregor <38837341+exitcode0@users.noreply.github.com> Co-authored-by: Guillaume Simard <2000390+GuiSim@users.noreply.github.com>

* main: (206 commits) Tiny: fix github casing (block#4903) remove anyOf from create_task tool (block#4897) chore(deps): bump tracing-subscriber from 0.3.19 to 0.3.20 (block#4442) fix optional recipe schema zod validation (block#4900) Added CMD+T keyboard shortcut that takes you to the Home tab (block#4541) feat(cli): add `path` & `limit` to `session list` command (block#4878) Allow better concurrent access (block#4896) fix: Windows prompt cursor positioning issue with ANSI escape sequences (block#4464) Fix: LiteLLM API key field not showing in UI configuration (block#4105) fix: path is duplicated on tool calls causing them to fail (block#4658) (block#4859) add new prompt to get all available tutorials (block#4802) Add filtering for agentVisible: false messages on streaming providers (block#4847) alexhancock/mcp-crate-cleanup (block#4885) docs: rename sub-recipe to subrecipe (block#4886) docs: new multi-model section with autopilot topic (block#4864) make agent manager singleton (block#4880) Cli web auth token (block#4456) fix(token_counter): fix panic with GitHub Copilot (block#4632) Revert "Internal MCP Crate Cleanup (block#4800)" (block#4883) remove 2 redundant comments and one that lies (block#4866) ...

… (block#4859) Signed-off-by: demetrio108 <demetrio108@protonmail.com> Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>

fix: path is duplicated on tool calls causing them to fail (block#4658)

ab0e57c

Signed-off-by: demetrio108 <demetrio108@protonmail.com>

demetrio108 force-pushed the fix-path-overlapping-4658 branch from be6a395 to ab0e57c Compare September 26, 2025 19:19

amed-xyz requested review from michaelneale and tlongwell-block September 26, 2025 23:41

michaelneale assigned tlongwell-block and michaelneale Sep 29, 2025

DOsinga reviewed Sep 29, 2025

View reviewed changes

code review fixes

26a81d5

Signed-off-by: demetrio108 <demetrio108@protonmail.com>

DOsinga approved these changes Sep 29, 2025

View reviewed changes

michaelneale merged commit 5c9be9a into block:main Sep 29, 2025
10 checks passed

angelahning mentioned this pull request Sep 30, 2025

Path is duplicated on tool calls causing them to fail #4658

Closed

This was referenced Oct 8, 2025

chore(release): release version 1.10.0 #5060

Closed

release/1.10.0 #5101

Closed

fix: path is duplicated on tool calls causing them to fail (#4658) #4859

fix: path is duplicated on tool calls causing them to fail (#4658) #4859

Uh oh!

Conversation

demetrio108 commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michaelneale commented Sep 29, 2025

Uh oh!

michaelneale commented Sep 29, 2025

Uh oh!

Uh oh!

DOsinga Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

demetrio108 Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DOsinga Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

demetrio108 Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

DOsinga Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

demetrio108 commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

demetrio108 commented Sep 29, 2025

Uh oh!

michaelneale commented Sep 29, 2025

Uh oh!

Uh oh!

demetrio108 commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

demetrio108 commented Sep 26, 2025 •

edited

Loading

demetrio108 commented Sep 29, 2025 •

edited

Loading

demetrio108 commented Sep 29, 2025 •

edited

Loading