fix: linux builds: use gcc 10 in Linux builds #4841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadeo
changed the title
jamadeo
changed the title
alexhancock
approved these changes
Sep 26, 2025
| target-suffix: unknown-linux-gnu | ||
| build-on: ubuntu-latest | ||
| use-cross: true | ||
| cc: gcc-10 |
Collaborator
There was a problem hiding this comment.
looks like latest stable version of gcc is 15. could we update all the way to newest?
Collaborator
Author
There was a problem hiding this comment.
quite possibly, yeah. I went with 10 because ubuntu 20 (what we're building on) ships with 9, and 10 is where the original issue is fixed: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189
according to some googling though, 10 is the latest in the official repositories for ubuntu 20 (I haven't verified) so it might mean some extra steps to get it working for not much gain
This reverts commit 1c28a05.
angiejones
pushed a commit
that referenced
this pull request
Sep 26, 2025
katzdave
added a commit
that referenced
this pull request
Sep 26, 2025
* 'main' of github.com:block/goose: Docs: Add link to Plug & Play video for Reddit MCP (#4852) remove only-pr-labels (#4842) Update video link in README.md to lowercase goose (#4846) chore: fix all warnings in test compilation (#4827) fix: linux builds: use gcc 10 in Linux builds (#4841) fix: keep one goosed client per BrowswerWindow (#4805) add automation for marking and closing stale PRs (#4826) chore: turn clippy on for test code (#4817) fix: pricing integration test (#4837) blog post on subagents vs subrecipes (#4829) fix chat button alignment and spacing for attachments (#4794) fix: remove nested double quotes in windows automation_script tool description (#4824) fix: a few things with the mcp snapshot test (#4818) Revert "fix(compaction): try to catch more context limit exceeded erors and compact" (#4820)
katzdave
added a commit
that referenced
this pull request
Sep 26, 2025
* 'main' of github.com:block/goose: Docs: Add link to Plug & Play video for Reddit MCP (#4852) remove only-pr-labels (#4842) Update video link in README.md to lowercase goose (#4846) chore: fix all warnings in test compilation (#4827) fix: linux builds: use gcc 10 in Linux builds (#4841) fix: keep one goosed client per BrowswerWindow (#4805) add automation for marking and closing stale PRs (#4826) chore: turn clippy on for test code (#4817) fix: pricing integration test (#4837)
katzdave
added a commit
that referenced
this pull request
Sep 29, 2025
…ovements * 'main' of github.com:block/goose: Update video link in README.md to lowercase goose (#4846) chore: fix all warnings in test compilation (#4827) fix: linux builds: use gcc 10 in Linux builds (#4841) fix: keep one goosed client per BrowswerWindow (#4805) add automation for marking and closing stale PRs (#4826) chore: turn clippy on for test code (#4817) fix: pricing integration test (#4837)
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
Signed-off-by: HikaruEgashira <[email protected]>
This was referenced Oct 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What broke: cryptographic dependency aws-lc-rs checks during compilation that the C compiler is one that is not affected by https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189. Our linux builds use Ubuntu 20, which ships with gcc 9, which is affected. This PR installs and uses gcc 10, which includes a fix and passes the aws-lc-rs build.