test: add test coverage for inspect_tools #4700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelneale
approved these changes
Sep 23, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
not sure if I am meant to close and open it to trigger it, but this one seems legit coverage improvement assuming it works!
tlongwell-block
force-pushed
the
goose/test-coverage-37
branch
from
80b1890 to
e4727e5
Compare
Contributor
Author
|
Collaborator
closing and reopening will do it! |
4 tasks
tlongwell-block
changed the title
katzdave
added a commit
that referenced
this pull request
Sep 25, 2025
…ovements * 'main' of github.com:block/goose: (23 commits) blog post on subagents vs subrecipes (#4829) fix chat button alignment and spacing for attachments (#4794) fix: remove nested double quotes in windows automation_script tool description (#4824) fix: a few things with the mcp snapshot test (#4818) Revert "fix(compaction): try to catch more context limit exceeded erors and compact" (#4820) test: add test coverage for Tools Inspector (#4700) feat: Parse and use retryDelay from Google API RateLimitExceeded errors (#4124) cleanup: remove unused link preview and goose response form components (#4795) fix build: latest bedrock version (#4812) prefer users SHELL (#4702) feat: update aws-sdk-bedrockruntime to enable AWS_BEARER_TOKEN_BEDROCK auth (#4327) correct the tests from an odd merge (#4804) docs: import yaml recipe (#4799) docs: Add openmetadata extension to goose mcp docs (#4547) Add elapsed time to the CLI output. (#4609) fix: Fix cell coordinate ordering in XlsxTool and add unit tests (#4551) Use gemini flash for summarization on open router (#4290) chore(deps): bump xcb from 1.5.0 to 1.6.0 (#4289) feat(shell): throw errors on interactive commands (#4788) feat: AgentManager - foundation for unified execution (#4389) (#4684) ...
Collaborator
I don't think this is testing anything useful. I think we should revert this. It is a lot of code that constructs a mock and everything but ultimately only tests if the inspection_manager returns a result a per inspector that you added and that the names of the inspectors and the order are the same of how you set it up. that doesn't strike me as very interesting |
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
Co-authored-by: tlongwell-block <[email protected]> Co-authored-by: Tyler Longwell <[email protected]> Signed-off-by: HikaruEgashira <[email protected]>
This was referenced Oct 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Automated Test Addition
This PR was automatically generated by Goose to improve test coverage.
What changed?
Added a unit test for a previously untested function.
Why?
Part of our daily automated test coverage improvement initiative. Goose analyzes the codebase to find untested but important functions and creates focused unit tests for them.
Review checklist
Metrics
Current Context Size
API Usage (Billable)
Generated by the Daily Test Coverage Finder workflow