Skip to content

Fix: Token count UI doesn't re-render if it's open. #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
katzdave merged 5 commits into from
Sep 26, 2025
Merged

Fix: Token count UI doesn't re-render if it's open. #4822

katzdave merged 5 commits into from
Sep 26, 2025

Conversation

@katzdave
Copy link
Collaborator

@katzdave katzdave commented Sep 25, 2025

Tracking the key forces re-renders every time the key changes (based on numTokens/limit).

This now works even if you constantly mouse over the UI.

@katzdave katzdave requested a review from DOsinga September 25, 2025 17:52
DOsinga
DOsinga approved these changes Sep 25, 2025
View reviewed changes
ui/desktop/src/components/ChatInput.tsx Outdated
},
compactIcon: <ScrollText size={12} />,
autoCompactThreshold: autoCompactThreshold,
key: `context-${numTokens}-${tokenLimit}`, // Force re-render on token count change
Copy link
Collaborator

@DOsinga DOsinga Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't strike me as the correct solution, at most a work around? why are we not rerendering this when the numTokens changes? it is in the alert properties. do we do a shallow compare somewhere?

ui/desktop/src/components/bottom_menu/BottomMenuAlertPopover.tsx Outdated
!prevAlert ||
prevAlert.type !== alert.type ||
prevAlert.message !== alert.message ||
prevAlert.key !== alert.key
Copy link
Collaborator

@DOsinga DOsinga Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see, the problem is that we don't detect changes in the right way. this should just do a deep compare I think

@katzdave
deep euqlaity
10d7aa1
@katzdave
Merge branch 'main' of github.com:block/goose into dkatz/token-ui
1b19bfd 
* 'main' of github.com:block/goose:
  Docs: Add link to Plug & Play video for Reddit MCP (#4852)
  remove only-pr-labels (#4842)
  Update video link in README.md to lowercase goose (#4846)
  chore: fix all warnings in test compilation (#4827)
  fix: linux builds: use gcc 10 in Linux builds (#4841)
  fix: keep one goosed client per BrowswerWindow (#4805)
  add automation for marking and closing stale PRs (#4826)
  chore: turn clippy on for test code (#4817)
  fix: pricing integration test (#4837)
  blog post on subagents vs subrecipes (#4829)
  fix chat button alignment and spacing for attachments (#4794)
  fix: remove nested double quotes in windows automation_script tool description (#4824)
  fix: a few things with the mcp snapshot test (#4818)
  Revert "fix(compaction): try to catch more context limit exceeded erors and compact" (#4820)
@katzdave katzdave merged commit 7451761 into main Sep 26, 2025
11 checks passed
@katzdave katzdave deleted the dkatz/token-ui branch September 26, 2025 18:02
katzdave added a commit that referenced this pull request Sep 29, 2025
@katzdave
Fix: Token count UI doesn't re-render if it's open. (#4822)
1943ff0
@katzdave katzdave mentioned this pull request Sep 29, 2025
Closed
matt-wirth added a commit to LiquidMetal-AI/goose that referenced this pull request Sep 30, 2025
@matt-wirth @angelahning
@emma-squared @katzdave @DOsinga @EbonyLouis @taniandjerry @angiejones @jamadeo @michaelneale @iandouglas @alexhancock @jsibbison-square @blackgirlbytes @jalateras @sings-to-bees-on-wednesdays @Evanfeenstra @yingjiehe-xyz @dianed-square @AdemolaAri @demetrio108 @claude @thebristolsound @exitcode0 @GuiSim
MCP workaround (#1)
e6b522f 
* remove only-pr-labels (block#4842)

Signed-off-by: Angela Ning <[email protected]>

* Docs: Add link to Plug & Play video for Reddit MCP (block#4852)

* Fix: Token count UI doesn't re-render if it's open. (block#4822)

* Update databricks flash model (block#4836)

* Session manager (block#4648)

Co-authored-by: Douwe Osinga <[email protected]>

* Add Hacktoberfest Guides (block#4830)

Co-authored-by: taniashiba <[email protected]>

* docs: goose x Hacktoberfest 2025 Blog (block#4855)

Co-authored-by: Tania Chakraborty <[email protected]>
Co-authored-by: Angie Jones <[email protected]>

* fix: delete some flaky and not-useful tests (block#4861)

* can tell the system what shell it is using (block#4807)

* new subrecipe blog post banner (block#4862)

* docs: remove recipe generator link from next to extension search (block#4858)

* lowercase g in goose (block#4832)

* doc: file parameter recipe update (block#4594)

* Fiie input recipe ref doc (block#4869)

* Add .goosehints file to enforce lowercase branding in documentation (block#4870)

Co-authored-by: Angie Jones <[email protected]>

* fix: restoring test data and correcting name (block#4875)

* Dead code cleanup (block#4873)

Co-authored-by: Douwe Osinga <[email protected]>
Co-authored-by: Michael Neale <[email protected]>

* Fix block#4612: Return non-zero exit code when CLI session ends with error (block#4621)

Signed-off-by: jalateras <[email protected]>

* Internal MCP Crate Cleanup (block#4800)

* remove 2 redundant comments and one that lies (block#4866)

Co-authored-by: Douwe Osinga <[email protected]>

* Revert "Internal MCP Crate Cleanup (block#4800)" (block#4883)

* fix(token_counter): fix panic with GitHub Copilot (block#4632)

Signed-off-by: sings-to-bees-on-wednesdays <[email protected]>

main was broken. this seems important

* Cli web auth token (block#4456)

Signed-off-by: Evanfeenstra <[email protected]>

* make agent manager singleton (block#4880)

* docs: new multi-model section with autopilot topic (block#4864)

* docs: rename sub-recipe to subrecipe (block#4886)

* alexhancock/mcp-crate-cleanup (block#4885)

* Temporary workaround for mcp server

* Add filtering for agentVisible: false messages on streaming providers (block#4847)

* add new prompt to get all available tutorials (block#4802)

Signed-off-by: AdemolaAri <[email protected]>

* Fix for auth in extension, fix for stale keychain

* fix: path is duplicated on tool calls causing them to fail (block#4658) (block#4859)

Signed-off-by: demetrio108 <[email protected]>

* Fix: LiteLLM API key field not showing in UI configuration (block#4105)

Signed-off-by: jalateras <[email protected]>
Co-authored-by: Ebony Louis <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Jack Amadeo <[email protected]>

* fix: Windows prompt cursor positioning issue with ANSI escape sequences (block#4464)

Signed-off-by: Matt Donovan <[email protected]>
Co-authored-by: Matt Donovan <[email protected]>

* Allow better concurrent access (block#4896)

Co-authored-by: Douwe Osinga <[email protected]>

* feat(cli): add `path` & `limit` to `session list` command (block#4878)

* Added CMD+T keyboard shortcut that takes you to the Home tab (block#4541)

Signed-off-by: Guillaume Simard <[email protected]>

---------

Signed-off-by: Angela Ning <[email protected]>
Signed-off-by: jalateras <[email protected]>
Signed-off-by: Evanfeenstra <[email protected]>
Signed-off-by: AdemolaAri <[email protected]>
Signed-off-by: demetrio108 <[email protected]>
Signed-off-by: Matt Donovan <[email protected]>
Signed-off-by: Guillaume Simard <[email protected]>
Co-authored-by: Angela Ning <[email protected]>
Co-authored-by: Emma Youndtsmith <[email protected]>
Co-authored-by: David Katz <[email protected]>
Co-authored-by: Douwe Osinga <[email protected]>
Co-authored-by: Douwe Osinga <[email protected]>
Co-authored-by: Ebony Louis <[email protected]>
Co-authored-by: taniashiba <[email protected]>
Co-authored-by: taniandjerry <[email protected]>
Co-authored-by: Tania Chakraborty <[email protected]>
Co-authored-by: Angie Jones <[email protected]>
Co-authored-by: Jack Amadeo <[email protected]>
Co-authored-by: Michael Neale <[email protected]>
Co-authored-by: w. ian douglas <[email protected]>
Co-authored-by: Alex Hancock <[email protected]>
Co-authored-by: Jarrod Sibbison <[email protected]>
Co-authored-by: Rizel Scarlett <[email protected]>
Co-authored-by: Jim Alateras <[email protected]>
Co-authored-by: sings-to-bees-on-wednesdays <[email protected]>
Co-authored-by: Evan Feenstra <[email protected]>
Co-authored-by: Yingjie He <[email protected]>
Co-authored-by: dianed-square <[email protected]>
Co-authored-by: Ademola Arigbabuwo <[email protected]>
Co-authored-by: Demetrio ⚡️ <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Jack Amadeo <[email protected]>
Co-authored-by: Matt Donovan <[email protected]>
Co-authored-by: Matt Donovan <[email protected]>
Co-authored-by: Robert Mcgregor <[email protected]>
Co-authored-by: Guillaume Simard <[email protected]>
HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025
@katzdave @HikaruEgashira
Fix: Token count UI doesn't re-render if it's open. (block#4822)
02593fc 
Signed-off-by: HikaruEgashira <[email protected]>
This was referenced Oct 8, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DOsinga DOsinga DOsinga approved these changes

@zanesq zanesq zanesq approved these changes

Assignees

@DOsinga DOsinga

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@katzdave @DOsinga @zanesq