Skip to content

Conversation

@jamadeo
Copy link
Collaborator

@jamadeo jamadeo commented Sep 26, 2025

The real fix here is that we should not have a test that breaks when an external API changes. If we want to keep this text around we should mock the API

@jamadeo jamadeo merged commit f5877a9 into main Sep 26, 2025
11 checks passed
@jamadeo jamadeo deleted the jackamadeo/fix-some-broken-things branch September 26, 2025 01:37
angiejones pushed a commit that referenced this pull request Sep 26, 2025
katzdave added a commit that referenced this pull request Sep 26, 2025
* 'main' of github.com:block/goose:
  Docs: Add link to Plug & Play video for Reddit MCP (#4852)
  remove only-pr-labels (#4842)
  Update video link in README.md to lowercase goose (#4846)
  chore: fix all warnings in test compilation (#4827)
  fix: linux builds: use gcc 10 in Linux builds (#4841)
  fix: keep one goosed client per BrowswerWindow (#4805)
  add automation for marking and closing stale PRs (#4826)
  chore: turn clippy on for test code (#4817)
  fix: pricing integration test (#4837)
  blog post on subagents vs subrecipes (#4829)
  fix chat button alignment and spacing for attachments (#4794)
  fix: remove nested double quotes in windows automation_script tool description (#4824)
  fix: a few things with the mcp snapshot test (#4818)
  Revert "fix(compaction): try to catch more context limit exceeded erors and compact" (#4820)
katzdave added a commit that referenced this pull request Sep 26, 2025
* 'main' of github.com:block/goose:
  Docs: Add link to Plug & Play video for Reddit MCP (#4852)
  remove only-pr-labels (#4842)
  Update video link in README.md to lowercase goose (#4846)
  chore: fix all warnings in test compilation (#4827)
  fix: linux builds: use gcc 10 in Linux builds (#4841)
  fix: keep one goosed client per BrowswerWindow (#4805)
  add automation for marking and closing stale PRs (#4826)
  chore: turn clippy on for test code (#4817)
  fix: pricing integration test (#4837)
@DOsinga
Copy link
Collaborator

DOsinga commented Sep 29, 2025

I think I'd delete the entire thing

katzdave added a commit that referenced this pull request Sep 29, 2025
…ovements

* 'main' of github.com:block/goose:
  Update video link in README.md to lowercase goose (#4846)
  chore: fix all warnings in test compilation (#4827)
  fix: linux builds: use gcc 10 in Linux builds (#4841)
  fix: keep one goosed client per BrowswerWindow (#4805)
  add automation for marking and closing stale PRs (#4826)
  chore: turn clippy on for test code (#4817)
  fix: pricing integration test (#4837)
katzdave pushed a commit that referenced this pull request Sep 29, 2025
@katzdave katzdave mentioned this pull request Sep 29, 2025
HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants