Skip to content

Conversation

@alexhancock
Copy link
Collaborator

@alexhancock alexhancock commented Sep 25, 2025

Removing unused code, and adding test cases where there was unused code that should have been used

@alexhancock alexhancock requested a review from jamadeo September 25, 2025 19:15
#[tokio::test]
async fn test_agent_with_anthropic() -> Result<()> {
run_test_with_config(TestConfig {
provider_type: ProviderType::Anthropic,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProviderType::Anthropic was previously unused in the file

@alexhancock alexhancock force-pushed the alexhancock/test-compilation-warnings branch from fe83e92 to 647a1d2 Compare September 26, 2025 01:39
Copy link
Collaborator

@angelahning angelahning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@alexhancock alexhancock merged commit 5ba4143 into main Sep 26, 2025
11 checks passed
@alexhancock alexhancock deleted the alexhancock/test-compilation-warnings branch September 26, 2025 15:19
katzdave added a commit that referenced this pull request Sep 26, 2025
* 'main' of github.com:block/goose:
  Docs: Add link to Plug & Play video for Reddit MCP (#4852)
  remove only-pr-labels (#4842)
  Update video link in README.md to lowercase goose (#4846)
  chore: fix all warnings in test compilation (#4827)
  fix: linux builds: use gcc 10 in Linux builds (#4841)
  fix: keep one goosed client per BrowswerWindow (#4805)
  add automation for marking and closing stale PRs (#4826)
  chore: turn clippy on for test code (#4817)
  fix: pricing integration test (#4837)
  blog post on subagents vs subrecipes (#4829)
  fix chat button alignment and spacing for attachments (#4794)
  fix: remove nested double quotes in windows automation_script tool description (#4824)
  fix: a few things with the mcp snapshot test (#4818)
  Revert "fix(compaction): try to catch more context limit exceeded erors and compact" (#4820)
katzdave added a commit that referenced this pull request Sep 26, 2025
* 'main' of github.com:block/goose:
  Docs: Add link to Plug & Play video for Reddit MCP (#4852)
  remove only-pr-labels (#4842)
  Update video link in README.md to lowercase goose (#4846)
  chore: fix all warnings in test compilation (#4827)
  fix: linux builds: use gcc 10 in Linux builds (#4841)
  fix: keep one goosed client per BrowswerWindow (#4805)
  add automation for marking and closing stale PRs (#4826)
  chore: turn clippy on for test code (#4817)
  fix: pricing integration test (#4837)
katzdave added a commit that referenced this pull request Sep 29, 2025
…ovements

* 'main' of github.com:block/goose:
  Update video link in README.md to lowercase goose (#4846)
  chore: fix all warnings in test compilation (#4827)
  fix: linux builds: use gcc 10 in Linux builds (#4841)
  fix: keep one goosed client per BrowswerWindow (#4805)
  add automation for marking and closing stale PRs (#4826)
  chore: turn clippy on for test code (#4817)
  fix: pricing integration test (#4837)
HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants