-
Notifications
You must be signed in to change notification settings - Fork 2.3k
chore: fix all warnings in test compilation #4827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhancock
commented
Sep 25, 2025
| #[tokio::test] | ||
| async fn test_agent_with_anthropic() -> Result<()> { | ||
| run_test_with_config(TestConfig { | ||
| provider_type: ProviderType::Anthropic, |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProviderType::Anthropic was previously unused in the file
fe83e92 to
647a1d2
Compare
angelahning
approved these changes
Sep 26, 2025
Collaborator
angelahning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
angiejones
pushed a commit
that referenced
this pull request
Sep 26, 2025
katzdave
added a commit
that referenced
this pull request
Sep 26, 2025
* 'main' of github.com:block/goose: Docs: Add link to Plug & Play video for Reddit MCP (#4852) remove only-pr-labels (#4842) Update video link in README.md to lowercase goose (#4846) chore: fix all warnings in test compilation (#4827) fix: linux builds: use gcc 10 in Linux builds (#4841) fix: keep one goosed client per BrowswerWindow (#4805) add automation for marking and closing stale PRs (#4826) chore: turn clippy on for test code (#4817) fix: pricing integration test (#4837) blog post on subagents vs subrecipes (#4829) fix chat button alignment and spacing for attachments (#4794) fix: remove nested double quotes in windows automation_script tool description (#4824) fix: a few things with the mcp snapshot test (#4818) Revert "fix(compaction): try to catch more context limit exceeded erors and compact" (#4820)
katzdave
added a commit
that referenced
this pull request
Sep 26, 2025
* 'main' of github.com:block/goose: Docs: Add link to Plug & Play video for Reddit MCP (#4852) remove only-pr-labels (#4842) Update video link in README.md to lowercase goose (#4846) chore: fix all warnings in test compilation (#4827) fix: linux builds: use gcc 10 in Linux builds (#4841) fix: keep one goosed client per BrowswerWindow (#4805) add automation for marking and closing stale PRs (#4826) chore: turn clippy on for test code (#4817) fix: pricing integration test (#4837)
katzdave
added a commit
that referenced
this pull request
Sep 29, 2025
…ovements * 'main' of github.com:block/goose: Update video link in README.md to lowercase goose (#4846) chore: fix all warnings in test compilation (#4827) fix: linux builds: use gcc 10 in Linux builds (#4841) fix: keep one goosed client per BrowswerWindow (#4805) add automation for marking and closing stale PRs (#4826) chore: turn clippy on for test code (#4817) fix: pricing integration test (#4837)
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
Signed-off-by: HikaruEgashira <[email protected]>
This was referenced Oct 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unused code, and adding test cases where there was unused code that should have been used