fix: delete some flaky and not-useful tests #4861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOsinga
approved these changes
Sep 26, 2025
matt-wirth
added a commit
to LiquidMetal-AI/goose
that referenced
this pull request
Sep 30, 2025
* remove only-pr-labels (block#4842) Signed-off-by: Angela Ning <aning@squareup.com> * Docs: Add link to Plug & Play video for Reddit MCP (block#4852) * Fix: Token count UI doesn't re-render if it's open. (block#4822) * Update databricks flash model (block#4836) * Session manager (block#4648) Co-authored-by: Douwe Osinga <douwe@squareup.com> * Add Hacktoberfest Guides (block#4830) Co-authored-by: taniashiba <126204004+taniashiba@users.noreply.github.com> * docs: goose x Hacktoberfest 2025 Blog (block#4855) Co-authored-by: Tania Chakraborty <tchakraborty@block.xyz> Co-authored-by: Angie Jones <jones.angie@gmail.com> * fix: delete some flaky and not-useful tests (block#4861) * can tell the system what shell it is using (block#4807) * new subrecipe blog post banner (block#4862) * docs: remove recipe generator link from next to extension search (block#4858) * lowercase g in goose (block#4832) * doc: file parameter recipe update (block#4594) * Fiie input recipe ref doc (block#4869) * Add .goosehints file to enforce lowercase branding in documentation (block#4870) Co-authored-by: Angie Jones <jones.angie@gmail.com> * fix: restoring test data and correcting name (block#4875) * Dead code cleanup (block#4873) Co-authored-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: Michael Neale <michael.neale@gmail.com> * Fix block#4612: Return non-zero exit code when CLI session ends with error (block#4621) Signed-off-by: jalateras <jima@comware.com.au> * Internal MCP Crate Cleanup (block#4800) * remove 2 redundant comments and one that lies (block#4866) Co-authored-by: Douwe Osinga <douwe@squareup.com> * Revert "Internal MCP Crate Cleanup (block#4800)" (block#4883) * fix(token_counter): fix panic with GitHub Copilot (block#4632) Signed-off-by: sings-to-bees-on-wednesdays <222684290+sings-to-bees-on-wednesdays@users.noreply.github.com> main was broken. this seems important * Cli web auth token (block#4456) Signed-off-by: Evanfeenstra <evanfeenstra@gmail.com> * make agent manager singleton (block#4880) * docs: new multi-model section with autopilot topic (block#4864) * docs: rename sub-recipe to subrecipe (block#4886) * alexhancock/mcp-crate-cleanup (block#4885) * Temporary workaround for mcp server * Add filtering for agentVisible: false messages on streaming providers (block#4847) * add new prompt to get all available tutorials (block#4802) Signed-off-by: AdemolaAri <ademola.ari@gmail.com> * Fix for auth in extension, fix for stale keychain * fix: path is duplicated on tool calls causing them to fail (block#4658) (block#4859) Signed-off-by: demetrio108 <demetrio108@protonmail.com> * Fix: LiteLLM API key field not showing in UI configuration (block#4105) Signed-off-by: jalateras <jima@comware.com.au> Co-authored-by: Ebony Louis <55366651+EbonyLouis@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Jack Amadeo <jackamadeo@squareup.com> * fix: Windows prompt cursor positioning issue with ANSI escape sequences (block#4464) Signed-off-by: Matt Donovan <mattddonovan@protonmail.com> Co-authored-by: Matt Donovan <mattddonovan@protonmail.com> * Allow better concurrent access (block#4896) Co-authored-by: Douwe Osinga <douwe@squareup.com> * feat(cli): add `path` & `limit` to `session list` command (block#4878) * Added CMD+T keyboard shortcut that takes you to the Home tab (block#4541) Signed-off-by: Guillaume Simard <2000390+GuiSim@users.noreply.github.com> --------- Signed-off-by: Angela Ning <aning@squareup.com> Signed-off-by: jalateras <jima@comware.com.au> Signed-off-by: Evanfeenstra <evanfeenstra@gmail.com> Signed-off-by: AdemolaAri <ademola.ari@gmail.com> Signed-off-by: demetrio108 <demetrio108@protonmail.com> Signed-off-by: Matt Donovan <mattddonovan@protonmail.com> Signed-off-by: Guillaume Simard <2000390+GuiSim@users.noreply.github.com> Co-authored-by: Angela Ning <32008323+angelahning@users.noreply.github.com> Co-authored-by: Emma Youndtsmith <90283317+emma-squared@users.noreply.github.com> Co-authored-by: David Katz <dkatz@squareup.com> Co-authored-by: Douwe Osinga <douwe@block.xyz> Co-authored-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: Ebony Louis <55366651+EbonyLouis@users.noreply.github.com> Co-authored-by: taniashiba <126204004+taniashiba@users.noreply.github.com> Co-authored-by: taniandjerry <126204004+taniandjerry@users.noreply.github.com> Co-authored-by: Tania Chakraborty <tchakraborty@block.xyz> Co-authored-by: Angie Jones <jones.angie@gmail.com> Co-authored-by: Jack Amadeo <jackamadeo@block.xyz> Co-authored-by: Michael Neale <michael.neale@gmail.com> Co-authored-by: w. ian douglas <ian.douglas@iandouglas.com> Co-authored-by: Alex Hancock <alexhancock@block.xyz> Co-authored-by: Jarrod Sibbison <72240382+jsibbison-square@users.noreply.github.com> Co-authored-by: Rizel Scarlett <rizel@squareup.com> Co-authored-by: Jim Alateras <jima@comware.com.au> Co-authored-by: sings-to-bees-on-wednesdays <222684290+sings-to-bees-on-wednesdays@users.noreply.github.com> Co-authored-by: Evan Feenstra <evanfeenstra@gmail.com> Co-authored-by: Yingjie He <yingjiehe@squareup.com> Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com> Co-authored-by: Ademola Arigbabuwo <49918815+AdemolaAri@users.noreply.github.com> Co-authored-by: Demetrio ⚡️ <35406575+demetrio108@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Jack Amadeo <jackamadeo@squareup.com> Co-authored-by: Matt Donovan <mattddonovan@proton.me> Co-authored-by: Matt Donovan <mattddonovan@protonmail.com> Co-authored-by: Robert Mcgregor <38837341+exitcode0@users.noreply.github.com> Co-authored-by: Guillaume Simard <2000390+GuiSim@users.noreply.github.com>
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>
This was referenced Oct 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These only ever seem to fail because of flakiness.
The test essentially only calls set_up_logging, writes some logs, and then asserts that:
that's all it does