Merged
Conversation
Cookie updated whenever ageRestrictedContent setting is changed or service is changed. Right now there is only a cookie for youtube, but cookies for other services could be added in the future. Problems with this approach: Even when the service is set to youtube, the downloader doesn't only request youtube urls e.g. it also sends reqeusts to i.ytimg.com, suggestqueries.google.com, and yt3.ggpht.com. The ageRestrictedContent cookie is not normally sent when sending requests to these other urls, so doing so might have unknown effects.
Now the age restricted content cookie is only sent when sending a request to youtube. There's no need to remove the cookie when the service changes because whether to add the cookie is determined by looking at the url the request is being sent to.
Currently translated at 99.4% (570 of 573 strings)
Currently translated at 100.0% (573 of 573 strings)
Currently translated at 85.1% (488 of 573 strings)
Currently translated at 29.6% (170 of 573 strings)
Allow time ago debug setting translation
Restricted mode setting for youtube
Currently translated at 100.0% (573 of 573 strings)
Currently translated at 39.7% (228 of 573 strings)
Currently translated at 100.0% (574 of 574 strings)
Currently translated at 100.0% (574 of 574 strings)
Currently translated at 99.6% (575 of 577 strings)
Upgrade some dependencies
on top of being unused, there were MANY problems for some languages: %s missing, only «one» quantity is translated…
Localisation fixes (Fix crashes, lint)
Closed
Stypox
force-pushed
the
release_0.19.4
branch
2 times, most recently
from
5255ea7 to
a92e445
Compare
TobiGr
approved these changes
May 29, 2020
|
sorry but i just want to ask if theres any working new pipe version for android 4.1.2 jellybean? |
Contributor
|
@lionel0013: https://github.com/TeamNewPipe/NewPipe-legacy/issues is the proper place to ask that, but as you could see, someone already made an issue there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
App
New
Improved
Fixed
Development
Extractor
New
Improved
vnd.youtube://IDform [YouTube] Support stream urls invnd.youtube://IDform NewPipeExtractor#324Fixed
Development
Utils.isNullOrEmpty()to remove duplicated code refactor: add Utils.isNullOrEmpty() NewPipeExtractor#315.gitignoreadd vscode / eclipse files to .gitignore NewPipeExtractor#330APK for testing
app-debug_RC2.zip
PLEASE REPORT NEW CRASHES IN THE CORRESPONDING ISSUE #3670