Block the gesture when touch it from NavigationBar or StatusBar.#3337
Merged
TobiGr merged 3 commits intoTeamNewPipe:devfrom May 9, 2020
Merged
Conversation
Collaborator
|
Works as intended and code looks good to me. |
Contributor
Author
|
Oops, I moved the method to the correct position. |
wb9688
requested changes
May 7, 2020
Contributor
wb9688
left a comment
wb9688
left a comment
There was a problem hiding this comment.
The code looks fine, other than that small thing. Could you squash your commits?
app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java
Outdated
Show resolved
Hide resolved
wb9688
previously approved these changes
May 9, 2020
Follow Checkstyle Move to PlayerGestureListener from VideoPlayerImpl Update app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java Co-authored-by: wb9688 <[email protected]>
wb9688
force-pushed
the
blocking-gesture-when-touch-from-navbar
branch
from
603751a to
0abd2bc
Compare
wb9688
approved these changes
May 9, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Long description of the changes in your PR
We can view them by swiping up from the navigation bar or swiping down from the status bar, without having to tap the screen on the player screen.
Until now, when you made such a move, the gesture got in the way and it didn't work well.
This PR will allow you to block gestures initiated from the navigation bar and status bar.
Testing apk
blocking-gesture.zip
Agreement