Skip to content

Conversation

@B0pol
Copy link
Member

@B0pol B0pol commented May 11, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

This would save me lots of git clean -d -f when I just wanna quickly check a file in vscode.

@Stypox
Copy link
Member

Stypox commented May 11, 2020

Shouldn't you also add *.vscode/?

@B0pol
Copy link
Member Author

B0pol commented May 11, 2020

Shouldn't you also add *.vscode/?

I've never encountered this file and it seems they doesn't exist by looking on internet.

@B0pol
Copy link
Member Author

B0pol commented May 11, 2020

Obviously we shouldn't add the things that are irrelevant to us.

Yes, that's why I won't add .vscode, it's irrelevant. It's not doing that when I use vscode. If it does, someone can open another PR.

@Stypox
Copy link
Member

Stypox commented May 11, 2020

Shouldn't you also add *.vscode/?

I've never encountered this file and it seems they doesn't exist by looking on internet.

This is the folder containing all vscode configuration for a project, how can you have never seen it? See https://code.visualstudio.com/docs/getstarted/settings

@B0pol
Copy link
Member Author

B0pol commented May 11, 2020

I don't now, i just press code newpipe or code newpipeextractor, or open folver via GUI, and i've never seen it. I'll try with vanilla vscode.

@B0pol
Copy link
Member Author

B0pol commented May 11, 2020

I've tried with vanilla vscode.

  1. I've never used workspaces, but just used open folder. That may be a reason why.
  2. I've tried to change some settings, and it was asked to create a .code-workspace file, but it didn't created any .vscode folder

Edit:
there are three settings:
img
and to create .vscode folder you've to edit folder settings.

@B0pol
Copy link
Member Author

B0pol commented May 12, 2020

Can this be merged?

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thank you, I am on the opposite side as I have never opened a folder ;-)
This looks good to me

@Stypox Stypox merged commit 60e6df7 into TeamNewPipe:dev May 13, 2020
@B0pol B0pol deleted the gitignore branch May 13, 2020 08:49
@wb9688
Copy link
Member

wb9688 commented May 13, 2020

Quoting what I said on IRC:

No, I didn't approve the NPE one for a reason: **/bin should be bin/ and **.vscode should be .vscode/

In .gitignore, it'll match any directory called "bin" with "bin/". "/bin/" would make it relative to the .gitignore file. So "**/bin" is pointless. "**.vscode" seems to do the same thing as "*.vscode", but the folder is always just called ".vscode", so you should just do ".vscode/". When it has a "/" at the end, it'll only match directories with that name instead of all inodes with that name, but it mainly makes it clearer to anyone reading it whether that's supposed to be a file or a folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants