Release 0.19.4

.gitignore

@@ -10,3 +10,11 @@
 *~
 .weblate
 *.class
+
+# vscode / eclipse files
+*.classpath
+*.project
+*.settings
+bin/
+.vscode/
+*.code-workspace

.travis.yml

@@ -5,13 +5,13 @@ android:
   components:
     # The BuildTools version used by NewPipe
     - tools
-    - build-tools-28.0.3
+    - build-tools-29.0.3
 
     # The SDK version used to compile NewPipe
-    - android-28
+    - android-29
 
 before_install: 
-  - yes | sdkmanager "platforms;android-28"
+  - yes | sdkmanager "platforms;android-29"
 script: ./gradlew -Dorg.gradle.jvmargs=-Xmx1536m assembleDebug lintDebug testDebugUnitTest
 
 licenses:

app/build.gradle

@@ -5,16 +5,16 @@ apply plugin: 'kotlin-kapt'
 apply plugin: 'checkstyle'
 
 android {
-    compileSdkVersion 28
-    buildToolsVersion '28.0.3'
+    compileSdkVersion 29
+    buildToolsVersion '29.0.3'
 
     defaultConfig {
         applicationId "org.schabi.newpipe"
         resValue "string", "app_name", "NewPipe"
         minSdkVersion 19
-        targetSdkVersion 28
-        versionCode 930
-        versionName "0.19.3"
+        targetSdkVersion 29
+        versionCode 940
+        versionName "0.19.4"
 
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true
@@ -66,6 +66,7 @@ android {
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
         targetCompatibility JavaVersion.VERSION_1_8
+        encoding 'utf-8'
     }
 
     // Required and used only by groupie
@@ -79,22 +80,22 @@ android {
 }
 
 ext {
-    androidxLibVersion = '1.0.0'
-    exoPlayerLibVersion = '2.10.8'
-    roomDbLibVersion = '2.1.0'
-    leakCanaryLibVersion = '1.5.4' //1.6.1
-    okHttpLibVersion = '3.12.6'
-    icepickLibVersion = '3.2.0'
-    stethoLibVersion = '1.5.0'
-    markwonVersion = '4.2.1'
-    checkstyleVersion = '8.31'
+    icepickVersion = '3.2.0'
+    checkstyleVersion = '8.32'
+    stethoVersion = '1.5.1'
+    leakCanaryVersion = '2.2'
+    exoPlayerVersion = '2.11.4'
+    androidxLifecycleVersion = '2.2.0'
+    androidxRoomVersion = '2.2.5'
+    groupieVersion = '2.8.0'
+    markwonVersion = '4.3.1'
 }
 
 checkstyle {
     configFile rootProject.file('checkstyle.xml')
     ignoreFailures false
     showViolations true
-    toolVersion = "${checkstyleVersion}"
+    toolVersion = checkstyleVersion
 }
 
 task runCheckstyle(type: Checkstyle) {
@@ -116,88 +117,96 @@ task runCheckstyle(type: Checkstyle) {
     }
 }
 
-tasks.withType(Checkstyle).each {
-    checkstyleTask -> checkstyleTask.doLast {
-        reports.all { report ->
-            def outputFile = report.destination
-            if (outputFile.exists() && outputFile.text.contains("severity=\"error\"")) {
-                throw new GradleException("There were checkstyle errors! For more info check $outputFile")
-            }
-        }
-    }
+configurations {
+    ktlint
+}
+
+task runKtlint(type: JavaExec) {
+    main = "com.pinterest.ktlint.Main"
+    classpath = configurations.ktlint
+    args "src/**/*.kt"
+}
+
+task formatKtlint(type: JavaExec) {
+    main = "com.pinterest.ktlint.Main"
+    classpath = configurations.ktlint
+    args "-F", "src/**/*.kt"
 }
 
 afterEvaluate {
-    preDebugBuild.dependsOn runCheckstyle
+    preDebugBuild.dependsOn runCheckstyle, runKtlint
 }
 
 dependencies {
     implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
 
+    implementation "frankiesardo:icepick:${icepickVersion}"
+    kapt "frankiesardo:icepick-processor:${icepickVersion}"
+
     debugImplementation "com.puppycrawl.tools:checkstyle:${checkstyleVersion}"
+    ktlint "com.pinterest:ktlint:0.35.0"
 
-    androidTestImplementation 'androidx.test.ext:junit:1.1.1'
-    androidTestImplementation "android.arch.persistence.room:testing:1.1.1"
-    androidTestImplementation('androidx.test.espresso:espresso-core:3.1.0', {
-        exclude module: 'support-annotations'
-    })
+    debugImplementation "com.facebook.stetho:stetho:${stethoVersion}"
+    debugImplementation "com.facebook.stetho:stetho-okhttp3:${stethoVersion}"
 
-    implementation 'com.github.TeamNewPipe:NewPipeExtractor:fc3a69ed54b393e3e4e3a78ae6e89edc1d47c45a'
-    testImplementation 'junit:junit:4.12'
-    testImplementation 'org.mockito:mockito-core:2.23.0'
+    debugImplementation "com.squareup.leakcanary:leakcanary-android:${leakCanaryVersion}"
+    implementation "com.squareup.leakcanary:leakcanary-object-watcher-android:${leakCanaryVersion}"
 
-    implementation 'androidx.appcompat:appcompat:1.1.0'
-    implementation "androidx.legacy:legacy-support-v4:${androidxLibVersion}"
-    implementation "com.google.android.material:material:${androidxLibVersion}"
-    implementation "androidx.recyclerview:recyclerview:${androidxLibVersion}"
-    implementation "androidx.legacy:legacy-preference-v14:${androidxLibVersion}"
-    implementation "androidx.cardview:cardview:${androidxLibVersion}"
-    implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
+    debugImplementation "androidx.multidex:multidex:2.0.1"
 
-    implementation 'com.xwray:groupie:2.7.0'
-    implementation 'com.xwray:groupie-kotlin-android-extensions:2.7.0'
+    testImplementation 'junit:junit:4.13'
+    testImplementation 'org.mockito:mockito-core:3.3.3'
 
-    implementation 'androidx.lifecycle:lifecycle-livedata:2.0.0'
-    implementation 'androidx.lifecycle:lifecycle-viewmodel:2.0.0'
-    implementation 'androidx.lifecycle:lifecycle-extensions:2.0.0'
+    androidTestImplementation "androidx.test.ext:junit:1.1.1"
+    androidTestImplementation "androidx.room:room-testing:${androidxRoomVersion}"
+    androidTestImplementation "androidx.test.espresso:espresso-core:3.2.0", {
+        exclude module: 'support-annotations'
+    }
 
-    // Originally in NewPipeExtractor
-    implementation 'com.github.TeamNewPipe:nanojson:1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751'
-    implementation 'org.jsoup:jsoup:1.9.2'
+    implementation 'com.github.TeamNewPipe:NewPipeExtractor:98055a3c3c17f2543a63d375a44c1d1f557fa76e'
 
-    implementation 'ch.acra:acra:4.9.2' //4.11
+    implementation "com.github.TeamNewPipe:nanojson:1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751"
+    implementation "org.jsoup:jsoup:1.13.1"
 
-    implementation 'com.nostra13.universalimageloader:universal-image-loader:1.9.5'
-    implementation 'de.hdodenhof:circleimageview:2.2.0'
-    implementation 'com.nononsenseapps:filepicker:4.2.1'
+    implementation "com.squareup.okhttp3:okhttp:3.12.11"
 
-    implementation "com.google.android.exoplayer:exoplayer:${exoPlayerLibVersion}"
-    implementation "com.google.android.exoplayer:extension-mediasession:${exoPlayerLibVersion}"
+    implementation "com.google.android.exoplayer:exoplayer:${exoPlayerVersion}"
+    implementation "com.google.android.exoplayer:extension-mediasession:${exoPlayerVersion}"
 
-    debugImplementation "com.facebook.stetho:stetho:${stethoLibVersion}"
-    debugImplementation "com.facebook.stetho:stetho-urlconnection:${stethoLibVersion}"
-    debugImplementation 'androidx.multidex:multidex:2.0.1'
+    implementation "com.google.android.material:material:1.1.0"
 
-    implementation 'io.reactivex.rxjava2:rxjava:2.2.2'
-    implementation 'io.reactivex.rxjava2:rxandroid:2.1.0'
-    implementation 'com.jakewharton.rxbinding2:rxbinding:2.1.1'
-    implementation 'org.ocpsoft.prettytime:prettytime:4.0.3.Final'
+    implementation "androidx.appcompat:appcompat:1.1.0"
+    implementation "androidx.preference:preference:1.1.1"
+    implementation "androidx.recyclerview:recyclerview:1.1.0"
+    implementation "androidx.cardview:cardview:1.0.0"
+    implementation "androidx.constraintlayout:constraintlayout:1.1.3"
 
-    implementation "androidx.room:room-runtime:${roomDbLibVersion}"
-    implementation "androidx.room:room-rxjava2:${roomDbLibVersion}"
-    kapt "androidx.room:room-compiler:${roomDbLibVersion}"
+    implementation "androidx.lifecycle:lifecycle-livedata:${androidxLifecycleVersion}"
+    implementation "androidx.lifecycle:lifecycle-viewmodel:${androidxLifecycleVersion}"
+    implementation "androidx.lifecycle:lifecycle-extensions:${androidxLifecycleVersion}"
 
-    implementation "frankiesardo:icepick:${icepickLibVersion}"
-    kapt "frankiesardo:icepick-processor:${icepickLibVersion}"
+    implementation "androidx.room:room-runtime:${androidxRoomVersion}"
+    implementation "androidx.room:room-rxjava2:${androidxRoomVersion}"
+    kapt "androidx.room:room-compiler:${androidxRoomVersion}"
 
-    debugImplementation "com.squareup.leakcanary:leakcanary-android:${leakCanaryLibVersion}"
-    releaseImplementation "com.squareup.leakcanary:leakcanary-android-no-op:${leakCanaryLibVersion}"
+    implementation "com.xwray:groupie:${groupieVersion}"
+    implementation "com.xwray:groupie-kotlin-android-extensions:${groupieVersion}"
 
-    implementation "com.squareup.okhttp3:okhttp:${okHttpLibVersion}"
-    debugImplementation "com.facebook.stetho:stetho-okhttp3:${stethoLibVersion}"
+    implementation "de.hdodenhof:circleimageview:3.1.0"
+    implementation "com.nostra13.universalimageloader:universal-image-loader:1.9.5"
 
     implementation "io.noties.markwon:core:${markwonVersion}"
     implementation "io.noties.markwon:linkify:${markwonVersion}"
+
+    implementation "com.nononsenseapps:filepicker:4.2.1"
+
+    implementation "ch.acra:acra-core:5.5.0"
+
+    implementation "io.reactivex.rxjava2:rxjava:2.2.19"
+    implementation "io.reactivex.rxjava2:rxandroid:2.1.1"
+    implementation "com.jakewharton.rxbinding2:rxbinding:2.2.0"
+
+    implementation "org.ocpsoft.prettytime:prettytime:4.0.5.Final"
 }
 
 static String getGitWorkingBranch() {

app/src/androidTest/java/org/schabi/newpipe/database/AppDatabaseTest.kt

@@ -116,4 +116,4 @@ class AppDatabaseTest {
         testHelper.closeWhenFinished(database)
         return database
     }
-}
+}