Search: add isCorrectedSearch() and fix YoutubeSearchExtractor#getSea…#311
Merged
wb9688 merged 8 commits intoTeamNewPipe:devfrom May 12, 2020
Merged
Search: add isCorrectedSearch() and fix YoutubeSearchExtractor#getSea…#311wb9688 merged 8 commits intoTeamNewPipe:devfrom
wb9688 merged 8 commits intoTeamNewPipe:devfrom
Conversation
wb9688
requested changes
Apr 12, 2020
extractor/src/main/java/org/schabi/newpipe/extractor/search/SearchExtractor.java
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/search/SearchInfo.java
Outdated
Show resolved
Hide resolved
...va/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeMusicSearchExtractor.java
Outdated
Show resolved
Hide resolved
...st/java/org/schabi/newpipe/extractor/services/youtube/search/YoutubeSearchExtractorTest.java
Outdated
Show resolved
Hide resolved
B0pol
force-pushed
the
fixSearchSuggestion
branch
from
e3733f4 to
ff83546
Compare
wb9688
approved these changes
Apr 12, 2020
B0pol
force-pushed
the
fixSearchSuggestion
branch
from
df1ff6f to
6d177e9
Compare
Member
Author
|
nothing has changed with the last push, I just messed up with my folders |
Stypox
requested changes
Apr 15, 2020
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Looks good to me, only one thing
extractor/src/main/java/org/schabi/newpipe/extractor/search/SearchInfo.java
Outdated
Show resolved
Hide resolved
5 tasks
Member
|
Could you rebase? |
Member
Author
|
I'm getting some failing tests so I'll check later |
Member
|
@B0pol: You just don't have the |
Member
Author
The main problem was the new nanojson version. Could you review if this part is ok? |
wb9688
requested changes
May 7, 2020
...va/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeMusicSearchExtractor.java
Outdated
Show resolved
Hide resolved
…rchSuggestion() isCorrectedSearch: see the javadoc getSearchSuggestion: in YoutubeSearchExtractor, it was giving the corrected search query. It now gives the suggested query, as it should
Member
Author
|
The failing test in YoutubeSeachExtractorTest, inner class PageTest, test duplicatedItemsCheck is failing with: |
Member
wb9688
approved these changes
May 12, 2020
This was referenced May 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See TeamNewPipe/NewPipe#3419 and TeamNewPipe/NewPipe#3419 (comment)
With TeamNewPipe/NewPipe#3419, I figured out two things:
YouTube (& YouTube Music) either corrects your query, or suggest another one.
I fixed the suggestion in YouTube which were actually the corrected query, and added a boolean to know if the query was corrected.