Change retry & subscribe buttons background color based on service color#3565
Merged
Stypox merged 2 commits intoTeamNewPipe:devfrom May 13, 2020
Merged
Change retry & subscribe buttons background color based on service color#3565Stypox merged 2 commits intoTeamNewPipe:devfrom
Stypox merged 2 commits intoTeamNewPipe:devfrom
Conversation
Member
|
|
Member
|
Is RedButton used anywhere else? If that's not the case it could be removed |
Member
Author
|
It's used for subscribe button |
Member
|
Can't the subscribe button also be changed? Its red background looks a little bit strage on platforms other than youtube, and in material guidelines buttons usually have the primary color (go here and search for |
Member
Author
|
Done @Stypox |
Stypox
approved these changes
May 13, 2020
Member
Stypox
left a comment
There was a problem hiding this comment.
Code looks good and everything works fine after some testing :-D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
Testing apk
app-debug.zip
Screenshots
Agreement