[PeerTube] playlist support #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
wb9688
reviewed
Apr 9, 2020
...ava/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubePlaylistExtractor.java
Outdated
Show resolved
Hide resolved
B0pol
force-pushed
the
playlists_peertube
branch
from
cb6d4ab to
fcb3f25
Compare
yausername
reviewed
Apr 11, 2020
...schabi/newpipe/extractor/services/peertube/linkHandler/PeertubeStreamLinkHandlerFactory.java
Outdated
Show resolved
Hide resolved
B0pol
force-pushed
the
playlists_peertube
branch
from
a98e417 to
982b28d
Compare
Contributor
|
Could you add subchannel stuff for playlists as well? |
B0pol
changed the title
wb9688
approved these changes
May 11, 2020
| } | ||
| PeertubeParsingHelper.validate(playlistVideos); | ||
|
|
||
| this.total = JsonUtils.getNumber(playlistVideos, "total").longValue(); |
Contributor
There was a problem hiding this comment.
This shouldn't happen like this, however it's not worth fixing it until my next page PR (where you could just make it a normal variable in the function), especially as it's done like this in the other PeerTube ListExtractors as well.
This was referenced May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added playlist support and removed code duplication with
getNextPageUrl()across peertube classes.