Display parent channel details

[Royosef]

What is it?

• Bug fix (user facing)
• Feature (user facing)
• Code base improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Add sub-channel details to channel fragment & video detail fragment

Relies on the following changes

TeamNewPipe/NewPipeExtractor#313

Testing apk

NewPipe_displayparentchanneldetails-debug.zip

Agreement

• I carefully read the contribution guidelines and agree to them.

[B0pol]

.

[B0pol]

There is one thing I've noticed while testing: I'm not a fan of the possibility to go to parent channel page directly in video page. The room is already tiny, and it's now divided by two, on my large phone it's hard to go on the one you want, on my small phone it's simply impossible to choose.

Words are better than images: red is the separation between channel (up) and parent (down)
.

[wb9688]

You broke the ability to open streams from a channel.

[Royosef]

There is one thing I've noticed while testing: I'm not a fan of the possibility to go to parent channel page directly in video page. The room is already tiny, and it's now divided by two, on my large phone it's hard to go on the one you want, on my small phone it's simply impossible to choose.

Words are better than images: red is the separation between channel (up) and parent (down)
.

@B0pol So, will the whole section navigate to the channel page? (Les vidéos de Framasoft in this case)

[B0pol]

There is one thing I've noticed while testing: I'm not a fan of the possibility to go to parent channel page directly in video page. The room is already tiny, and it's now divided by two, on my large phone it's hard to go on the one you want, on my small phone it's simply impossible to choose.

Words are better than images: red is the separation between channel (up) and parent (down)
.

@B0pol So, will the whole section navigate to the channel page? (Les vidéos de Framasoft in this case)

@wb9688 asked me to reply but we've already talked about that via IRC, I just make it public:

Yes, the whole section will go to Les vidéos de Framasoft in this case. Unless someone find a good way to access seamlessly to both, it should go to the (sub)channel page.

But don't remove this part from the extractor because it's not only used by NewPipe, or someone in another PR will success to integrate it seamlessly…

[wb9688]

Unless someone find a good way to access seamlessly to both, it should go to the (sub)channel page.

Maybe use long press for parent channel while using a normal tap for (sub)channel.

[Royosef]

Unless someone find a good way to access seamlessly to both, it should go to the (sub)channel page.

Maybe use long press for parent channel while using a normal tap for (sub)channel.

Honestly, I don't know how much intuitive it will be for the users.

[wb9688]

@Royosef: It's better than nothing, and we have long presses on other buttons on that page as well.

@TobiGr: What do you think?

[TobiGr]

I agree with @wb9688. Long-press is better than nothing.

[opusforlife2]

There is already a setting to show a tip for background and popup buttons. It could be modified to also show one for this so that users get to know of the change.

[wb9688]

@opusforlife2: I don't think that's needed as it's currently only a PeerTube thing, and we don't have a tip for the download button either.

[opusforlife2]

Alright. If it's a Peertube specific feature and not app wide, I can imagine it would be tougher to implement.

Yeah, I got to know of the download button from your reddit comments. There really should be a tool tip for it.

[Stypox]

A few questions, but in general this is good to go :-D