master sync - PR https://github.com/apache/iceberg/pull/4926 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Xi Chen <[email protected]> Co-authored-by: Hao Lin <[email protected]>
I think we forgot to update the home page from the Parquet block.
The in-memory `InputFile` and `OutputFile` implementations has an undesirable property that returned streams allowed use after close. Since most streams don't have such property, it should be disallowed here too.
…e#5022) Co-authored-by: Prashant Singh <[email protected]>
Metaclasses in Python don't mix very well, and when they cause conflicts then it breaks at initialization. Example of metaclasses is the ABC, but also the Pydantic BaseModel. I tried to circumvent this by extending the Singleton from ABC but it is likely that we use different metaclasses in the future, and then it will bring us sadness and misery.
Currently, the properties are optional, which doesn't really make sense. Also, in the Java code it throws an exception: https://github.com/apache/iceberg/blob/master/core/src/test/java/org/apache/iceberg/rest/requests/TestRenameTableRequest.java#L106-L121 Therefore I would suggest making those required in the spec as well
* Remove redundant call to String.valueOf in format argument * Remove redundant warning suppression The unchecked code was removed in 9384bd6. * Include actual class name in class mismatch exception Include requested and actual class name in the exception message thrown when `PartitionData` detects type mismatch.
Co-authored-by: Prashant Singh <[email protected]>
``` ➜ python git:(fd-bump-pre-commit) pre-commit autoupdate Updating https://github.com/pre-commit/pre-commit-hooks ... updating v4.2.0 -> v4.3.0. Updating https://github.com/ambv/black ... already up to date. Updating https://github.com/pre-commit/mirrors-isort ... already up to date. Updating https://github.com/pre-commit/mirrors-mypy ... updating v0.960 -> v0.961. Updating https://github.com/hadialqattan/pycln ... already up to date. Updating https://github.com/asottile/pyupgrade ... updating v2.32.1 -> v2.34.0. ➜ python git:(fd-bump-pre-commit) ✗ pre-commit run --all-files trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check docstring is first.................................................Passed debug statements (python)................................................Passed check yaml...............................................................Passed check python ast.........................................................Passed black....................................................................Passed isort....................................................................Passed mypy.....................................................................Passed pycln....................................................................Passed pyupgrade................................................................Passed ```
* Python: Renable pylint For some reason pylint fell through the cracks when migrating from tox to pre-commit * Be more explicit in disabled checks
* Shutdown refresh token thread during REST catalog client close * Improved shutdown of token refresh executor during REST catalog close * REST: Set table format version for create table transactions * add test for creating v2 table via transaction * Core: Check for valid identifiers in REST catalog
…ils (apache#5366) Co-authored-by: Prashant Singh <[email protected]>
* Convert And, Or, and Not to dataclasses. * Refactor base expression types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.