AWS: Call abortUpload only once when any of the completable future fails

[singhpk234]

About the Change :

Presently whenever a failure is observed in any of the completableFutures in uploadParts(), it causes further completable futures fail with FileNotFoundException, when it tries to create a request for it using RequestBody.fromFile(file), as all the stagings files deleted as part of abortUpload which is called on failure of first completableFuture.

iceberg/aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java

Line 306 in 7a92bf5

UploadPartResponse response = s3.uploadPart(uploadRequest, RequestBody.fromFile(f));

I think this is what was also highlighted in @stevenzwu 's observation here (#4168 (comment))

This change attempts :

• To avoid unnecessary deletes being called for all staging files on every completableFutures which fail due to fileNotFoundException.
• Cancels the remaining futures in which would not be required as the abort is called, reduces number of calls to abort multi-part upload as well.

Testing Done

Existing UT's + a UT to see abort is called only once rather than atleast once.

cc @rdblue @jackye1995 @RussellSpitzer @stevenzwu @amogh-jahagirdar @rajarshisarkar

[singhpk234]

This PR can also fix the flakyness of TestS3OutputStream#testAbortAfterFailedPartUpload in recent runs of master.

[RussellSpitzer]

Thanks @singhpk234 and thanks @saswata-dutta for review!

[singhpk234]

Thanks @saswata-dutta , @RussellSpitzer for the review :) !

[nastra]

LGTM, thanks for fixing this