[Core | Docs]: [FOLLOWUP] Add metadata_log_entries metadata table #5367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szehon-ho
reviewed
Jul 27, 2022
singhpk234
force-pushed
the
docs/add-docs-for-metadata-log-entry
branch
from
34c9075 to
4ac5bd0
Compare
rdblue
reviewed
Jul 27, 2022
docs/spark-queries.md
Outdated
| To show table metadata logs: | ||
|
|
||
| ```sql | ||
| SELECT * from prod.db.table.metadata_logs |
Contributor
There was a problem hiding this comment.
Can we rename this metadata table? The name metadata_logs doesn't make sense to me since there is just the one log. The rows of the table are log entries.
Contributor
Author
There was a problem hiding this comment.
sure, should i then rename it to metadata_log_entries ?
rdblue
reviewed
Jul 27, 2022
added 2 commits
July 28, 2022 10:10
singhpk234
force-pushed
the
docs/add-docs-for-metadata-log-entry
branch
from
4ac5bd0 to
b149209
Compare
singhpk234
changed the title
singhpk234
force-pushed
the
docs/add-docs-for-metadata-log-entry
branch
from
b149209 to
8dc40a0
Compare
Member
|
Lets give a day or two for other comment, will merge the name change and doc if there is none |
Member
|
Merged , thanks @singhpk234 , we can follow up if there are more concerns. |
Contributor
Author
|
Thanks for the review @szehon-ho, @rdblue ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the change
cc @samredai, @szehon-ho