Nessie: Properly close all resources in NessieCatalog #5047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public void close() { | ||
| client.close(); | ||
| public void close() throws IOException { | ||
| if (null != closeableGroup) { |
Member
There was a problem hiding this comment.
nit: do we need this null check? I don't see other catalogs doing it.
Contributor
Author
There was a problem hiding this comment.
I know others don't have it but I feel that we could potentially still run into a case where closeableGroup hasn't been initialized because some preivous code in initialize(...) failed and if close() is called at some place, then it would throw a NPE
ajantha-bhat
approved these changes
Jun 15, 2022
| this.catalogOptions = Preconditions.checkNotNull(catalogOptions, "catalogOptions must be non-null"); | ||
| this.warehouseLocation = validateWarehouseLocation(name, catalogOptions); | ||
| this.closeableGroup = new CloseableGroup(); | ||
| closeableGroup.addCloseable(client::close); |
Contributor
Author
There was a problem hiding this comment.
the result would be the same but having just client here looks cleaner, so I pushed the change
nastra
force-pushed
the
nessie-close-resources
branch
from
2bea794 to
2dc5455
Compare
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.