Core: Check for valid identifiers in REST catalog #5107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
* Shutdown refresh token thread during REST catalog client close * Improved shutdown of token refresh executor during REST catalog close * REST: Set table format version for create table transactions * add test for creating v2 table via transaction * Core: Check for valid identifiers in REST catalog
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
* Shutdown refresh token thread during REST catalog client close * Improved shutdown of token refresh executor during REST catalog close * REST: Set table format version for create table transactions * add test for creating v2 table via transaction * Core: Check for valid identifiers in REST catalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checks for valid identifiers before performing certain catalog operations in the REST catalog. Currently, the pathing for most REST requests includes the namespace as part of the path. This adds checks that the namespace is not empty to prevent the REST catalog from building a path with
//. Using double slashes in the path is considered a security vulnerability by some frameworks so seems best to avoid.