Core: In HadoopTableOperations, replace Util.getFs call with getFileSystem #5062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
approved these changes
Jun 16, 2022
Member
ajantha-bhat
left a comment
ajantha-bhat
left a comment
There was a problem hiding this comment.
Thanks for the contribution @chakradhar2
Contributor
|
Thanks @chakradhar2 for the fix and @ajantha-bhat for the review! |
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HadoopTableOperations, we use getFileSystem method to get FileSystem, which internally calls Util.getFs but it was missing in some methods.
Using getFileSystem at all places in HadoopFileSystem allows to overriding method.