Skip to content

Conversation

@xingfanx
Copy link
Contributor

@xingfanx xingfanx commented Jun 18, 2022

augment to: #5041

integration test passed

> Task :iceberg-aws:integrationTest
[Test worker] INFO org.apache.iceberg.aws.glue.GlueCatalog - Created namespace: dd-dd
[Test worker] INFO org.apache.iceberg.BaseMetastoreCatalog - Table properties set at catalog level through catalog properties: {}
[Test worker] INFO org.apache.iceberg.BaseMetastoreCatalog - Table properties enforced at catalog level through catalog properties: {}
[Test worker] INFO org.apache.iceberg.BaseMetastoreTableOperations - Successfully committed to table glue.dd-dd.cc-cc in 1992 ms
BUILD SUCCESSFUL in 21s
14 actionable tasks: 1 executed, 13 up-to-date
2:54:01 PM: Execution finished ':iceberg-aws:integrationTest --tests "org.apache.iceberg.aws.glue.TestGlueCatalogTable.testCommitTableSkipNameValidation"'.

@github-actions github-actions bot added the AWS label Jun 18, 2022
@jackye1995
Copy link
Contributor

Overall looks good! Just to avoid we miss any additional edge case, can you add an integration test just to test end to end?

Copy link
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@jackye1995 jackye1995 merged commit 120cbe9 into apache:master Jun 20, 2022
namrathamyske pushed a commit to namrathamyske/iceberg that referenced this pull request Jul 10, 2022
namrathamyske pushed a commit to namrathamyske/iceberg that referenced this pull request Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants