Skip to content

AWS: add skip name validation config for glue namespace #5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackye1995 merged 9 commits into from
Jun 15, 2022
Merged

AWS: add skip name validation config for glue namespace #5041

jackye1995 merged 9 commits into from
Jun 15, 2022

Conversation

@xingfanx
Copy link
Contributor

@xingfanx xingfanx commented Jun 14, 2022 •
edited
Loading

Add a configuration awsProperties.glueCatalogSkipNameValidation() which allows characters like - in glue catalog namespaces

Tested with unittests.

> Task :iceberg-aws:test
BUILD SUCCESSFUL in 9s
13 actionable tasks: 1 executed, 12 up-to-date
4:07:42 PM: Execution finished ':iceberg-aws:test --tests "org.apache.iceberg.aws.glue.TestIcebergToGlueConverter"'.

@github-actions github-actions bot added the AWS label Jun 14, 2022
@xingfanx xingfanx changed the title AWS: add skip name validation for glue namespace AWS: add skip name validation config for glue namespace Jun 14, 2022
jackye1995
jackye1995 reviewed Jun 14, 2022
View reviewed changes
jackye1995
jackye1995 reviewed Jun 14, 2022
View reviewed changes
jackye1995
jackye1995 reviewed Jun 14, 2022
View reviewed changes
amogh-jahagirdar
amogh-jahagirdar reviewed Jun 14, 2022
View reviewed changes
@github-actions github-actions bot added the docs label Jun 14, 2022
jackye1995
jackye1995 reviewed Jun 15, 2022
View reviewed changes
jackye1995
jackye1995 reviewed Jun 15, 2022
View reviewed changes
jackye1995
jackye1995 reviewed Jun 15, 2022
View reviewed changes
jackye1995
jackye1995 reviewed Jun 15, 2022
View reviewed changes
jackye1995
jackye1995 reviewed Jun 15, 2022
View reviewed changes
jackye1995
jackye1995 approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@jackye1995
Copy link
Contributor

jackye1995 commented Jun 15, 2022

@amogh-jahagirdar any other comments?

@amogh-jahagirdar
Copy link
Contributor

amogh-jahagirdar commented Jun 15, 2022

@jackye1995 just some indentation stuff, the logic and the docs look good to me. I think my comments should cover where I think the continuing indentation needs to be updated, but let me know if I missed places

@amogh-jahagirdar
Copy link
Contributor

amogh-jahagirdar commented Jun 15, 2022

LGTM thanks for the contribution!

@xingfanx
Copy link
Contributor Author

xingfanx commented Jun 15, 2022

@amogh-jahagirdar updated

@jackye1995 jackye1995 merged commit 5653a0d into apache:master Jun 15, 2022
This was referenced Jun 18, 2022
Closed
Merged
namrathamyske pushed a commit to namrathamyske/iceberg that referenced this pull request Jul 10, 2022
@xingfanx
AWS: add skip name validation config for glue namespace and table (ap…
a495360 
…ache#5041)
namrathamyske pushed a commit to namrathamyske/iceberg that referenced this pull request Jul 10, 2022
@xingfanx
AWS: add skip name validation config for glue namespace and table (ap…
531a0e6 
…ache#5041)
@devinrsmith devinrsmith mentioned this pull request Feb 5, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackye1995 jackye1995 jackye1995 approved these changes

@amogh-jahagirdar amogh-jahagirdar amogh-jahagirdar approved these changes

Assignees

No one assigned

Labels

AWS docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xingfanx @jackye1995 @amogh-jahagirdar