-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime auto #8643
Runtime auto #8643
Commits on Oct 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 578c176 - Browse repository at this point
Copy the full SHA 578c176View commit details
Commits on Oct 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e8cc97c - Browse repository at this point
Copy the full SHA e8cc97cView commit details
Commits on Oct 31, 2022
-
[Collapsible] Remove deprecated Collapsible argument (#7397)
### WHY are these changes introduced? Removes a deprecated argument on the Collapsible component with the major version bump. ### WHAT is this pull request doing? Removes the prop as a breaking change. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) N/A tophatting instructions as Polaris does not use this prop internally. ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for d2d396f - Browse repository at this point
Copy the full SHA d2d396fView commit details
Commits on Nov 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4ac85a1 - Browse repository at this point
Copy the full SHA 4ac85a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13d95f0 - Browse repository at this point
Copy the full SHA 13d95f0View commit details
Commits on Nov 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bf9035b - Browse repository at this point
Copy the full SHA bf9035bView commit details
Commits on Dec 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e10c1e1 - Browse repository at this point
Copy the full SHA e10c1e1View commit details
Commits on Jan 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e811088 - Browse repository at this point
Copy the full SHA e811088View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1441b7a - Browse repository at this point
Copy the full SHA 1441b7aView commit details
Commits on Jan 10, 2023
-
Change Breadcrumbs to accept a single breadcrumb instead of an array (#…
…7990) ### WHY are these changes introduced? Breadcrumbs has only been using a single breadcrumb for a while now. Instead of allowing consumers to pass an array without knowing why only a single link is being used, we should remove the ability to pass an array and make the component easier to understand implicitly. ### WHAT is this pull request doing? UI will not change. The Breadcrumbs component was already only using the last breadcrumb link in the array. This PR changes the props for breadcrumbs and also the implementation on the Page component. ### Migration path Since this PR removes the `breadcrumbs[]` prop in favor of `breadcrumb` all uses of Page, and Breadcrumbs will need to be migrated. It will look something like this: ```ts //before const breadcrumbs = [ { content: 'Products', url: 'http://test.com', }, ]; <Page {...mockProps} breadcrumbs={breadcrumbs} /> //after const breadcrumb = { content: 'Products', url: 'http://test.com', }; <Page {...mockProps} breadcrumb={breadcrumb} /> ``` ### How to 🎩 Check the Breadcrumbs and Page components in storybook ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 590711c - Browse repository at this point
Copy the full SHA 590711cView commit details
Commits on Jan 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 690b6cf - Browse repository at this point
Copy the full SHA 690b6cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8de5271 - Browse repository at this point
Copy the full SHA 8de5271View commit details -
Remove
beta
status fromText
(#8187)### WHY are these changes introduced? Now that the admin has been migrated to use Text, we can mark `Text` as stable in v11. ### WHAT is this pull request doing? Removes beta status and message banner from `Text` component page. <details> <summary>Update Text component page</summary> <img src="https://user-images.githubusercontent.com/26749317/215123915-0ed9fef9-d4f7-413a-a31e-73d4e80fec28.png" alt="Update Text component page"> </details> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for f5ad75f - Browse repository at this point
Copy the full SHA f5ad75fView commit details -
Remove deprecated typography components (#8184)
### WHY are these changes introduced? Resolves #6511. Now that `Shopify/web` has been migrated to use the `Text` component, we can safely remove the 6 deprecated typography components. Note: The 3 chromatic changes are related to other changes in the v11 branch and not this PR. ### WHAT is this pull request doing? Removes `DisplayText`, `Heading`, `Subheading`, `Caption`, `TextStyle`, and `VisuallyHidden`. <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for a1318f8 - Browse repository at this point
Copy the full SHA a1318f8View commit details
Commits on Jan 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ba75af4 - Browse repository at this point
Copy the full SHA ba75af4View commit details
Commits on Jan 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 62593f3 - Browse repository at this point
Copy the full SHA 62593f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73a6bc5 - Browse repository at this point
Copy the full SHA 73a6bc5View commit details
Commits on Jan 30, 2023
-
1/x Bump build dependencies (#8200)
### WHY are these changes introduced? Rollup and Babel are blocking our migration to minimum NodeJS version 16. This PR updated all Rollup and Babel dependencies. These NPM package upgrades are not compatible with NodeJS 14.17 (main branch version). This change unblocks a larger change to our NodeJS versions. ### WHAT is this pull request doing? - [x] Moves duplicate dependencies to root - [x] Upgrades all rollup and babel dependencies - [x] Fixes any required breaking changes or warnings - [x] Compared diff of previous packages and new ones and it doesn't have a regression ### How to 🎩 1. Run a build on `main` save the built files on desktop 1. Run a build on this `bump-build-deps` save the built files on desktop 1. Run a diff over the built files 1. Make sure no regressions 1. CI, tests should pass and website should render all pages. **@alex-page's output from Diff:** [diff.zip](https://github.com/Shopify/polaris/files/10531068/diff.zip) ``` diff -bur polaris-tokens/dist-main polaris-tokens/dist-v11 > icons.diff diff -bur polaris-tokens/dist-main polaris-tokens/dist-v11 > tokens.diff diff -bur polaris-migrator/dist-main polaris-migrator/dist-v11 > migrator.diff diff -bur polaris-react/build-main polaris-react/build-v11 > react.diff ``` ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for ff6248c - Browse repository at this point
Copy the full SHA ff6248cView commit details -
2/x Bump NodeJS supported versions to ^16.16 || ^18.13 (#8201)
### WHY are these changes introduced? NodeJS 14 is EOL and we are removing support in v11. We currently set `engines` on the root `package.json`. The problem with this is that consumers of the library do not get this information and they can use the libraries without any warning of what version of NodeJS it supports. ### WHAT is this pull request doing? - [x] Increasing the supported versions of NodeJS - [x] Add the engines field for NodeJS to package.json files I would like to get NodeJS to version 16.19 before we launch version 11. However there is an issue with babel/rollup/browserslist not finding the latest version of NodeJS: ``` (plugin babel) BrowserslistError: Unknown version 16.19 of Node.js ``` ### How to 🎩 - CI completes successfully
Configuration menu - View commit details
-
Copy full SHA for 89c8ae4 - Browse repository at this point
Copy the full SHA 89c8ae4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bc5ac9 - Browse repository at this point
Copy the full SHA 3bc5ac9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7691259 - Browse repository at this point
Copy the full SHA 7691259View commit details -
Adjust NodeJS versions so we support LTS 16/18 and future versions (#…
…8211) Co-Authored-By: Ben Scott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0f0dca0 - Browse repository at this point
Copy the full SHA 0f0dca0View commit details
Commits on Feb 1, 2023
-
Re-add deprecated typography docs (#8206)
### WHY are these changes introduced? Re-adds the deprecated typography docs and images on the style guide so that users can still reference them. The `get-props` script had to be updated to resolve build errors. It was failing since the component files no longer existed in `polaris-react/src/components`. ### WHAT is this pull request doing? - Re-add dep components images - Re-add dep component pages - ~Adds new `deprecatedComponents` array to the `get-props` file and if the parsed file matches any of the elements, return empty object~ - If component status is deprecated, props table is not rendered on component page <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 1333261 - Browse repository at this point
Copy the full SHA 1333261View commit details -
Configuration menu - View commit details
-
Copy full SHA for 294326f - Browse repository at this point
Copy the full SHA 294326fView commit details
Commits on Feb 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fa47aa5 - Browse repository at this point
Copy the full SHA fa47aa5View commit details -
Remove downlevel-dts and legacy type support (#8203)
### WHY are these changes introduced? Polaris currently supports multiple TypeScript versions by building our types twice. This breaking change in v11 removes this functionality and we will only support the current version in the library. This used to be required to build the props table on legacy.polaris.shopify.com. This is no longer a requirement with @martenbjork brilliant work. ### WHAT is this pull request doing? Removes legacy type support for the library. --------- Co-authored-by: Ben Scott <[email protected]> Co-authored-by: Aaron Casanova <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6215f5c - Browse repository at this point
Copy the full SHA 6215f5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b348834 - Browse repository at this point
Copy the full SHA b348834View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37cacc5 - Browse repository at this point
Copy the full SHA 37cacc5View commit details
Commits on Feb 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a766dec - Browse repository at this point
Copy the full SHA a766decView commit details
Commits on Feb 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d3de5ab - Browse repository at this point
Copy the full SHA d3de5abView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0ac7a5 - Browse repository at this point
Copy the full SHA b0ac7a5View commit details
Commits on Feb 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b686bc7 - Browse repository at this point
Copy the full SHA b686bc7View commit details
Commits on Feb 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c07bf0c - Browse repository at this point
Copy the full SHA c07bf0cView commit details
Commits on Feb 15, 2023
-
Remove support for React 16 and 17 (#8340)
### WHY are these changes introduced? Fixes #8331 ### WHAT is this pull request doing? Removing support for v16 and v17 from Shopify Polaris.
Configuration menu - View commit details
-
Copy full SHA for 79f40cd - Browse repository at this point
Copy the full SHA 79f40cdView commit details
Commits on Feb 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 994bb90 - Browse repository at this point
Copy the full SHA 994bb90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87ca999 - Browse repository at this point
Copy the full SHA 87ca999View commit details -
Merge branch 'v11-major' of https://github.com/Shopify/polaris into v…
…11-major
Configuration menu - View commit details
-
Copy full SHA for 2867843 - Browse repository at this point
Copy the full SHA 2867843View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11d56c5 - Browse repository at this point
Copy the full SHA 11d56c5View commit details
Commits on Feb 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e288ca6 - Browse repository at this point
Copy the full SHA e288ca6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 641297f - Browse repository at this point
Copy the full SHA 641297fView commit details -
[Layout foundations] Replace Card with AlphaCard (#8468)
### WHY are these changes introduced? Resolves #8458, #8101, and #8376. Replaces `Card` with `AlphaCard`. ### WHAT is this pull request doing? - Replace Card with AlphaCard in polaris-react - Removes Card and examples in polaris.shopify.com - Updates any card links in style guide (links to content specifically in the `card.md` file was updated to point to `legacy-card.md`) - Removes temporary support for `Polaris-Card` class overrides in `LegacyCard` ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 5985838 - Browse repository at this point
Copy the full SHA 5985838View commit details
Commits on Feb 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 04d1e51 - Browse repository at this point
Copy the full SHA 04d1e51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 971ceb3 - Browse repository at this point
Copy the full SHA 971ceb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e03ab7 - Browse repository at this point
Copy the full SHA 9e03ab7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0070f64 - Browse repository at this point
Copy the full SHA 0070f64View commit details -
Change breadcrumb to backlink (#8465)
### WHY are these changes introduced? Adjusting the syntax of the v11 change to `backLink` Also note that breadcrumbs are no longer supported in v11. ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Sam Rose <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 68fd9c0 - Browse repository at this point
Copy the full SHA 68fd9c0View commit details
Commits on Mar 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f5cf669 - Browse repository at this point
Copy the full SHA f5cf669View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e7c41e - Browse repository at this point
Copy the full SHA 4e7c41eView commit details
Commits on Mar 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ed504b4 - Browse repository at this point
Copy the full SHA ed504b4View commit details
Commits on Mar 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 60940f7 - Browse repository at this point
Copy the full SHA 60940f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b95a8b - Browse repository at this point
Copy the full SHA 1b95a8bView commit details
Commits on Mar 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 35a4089 - Browse repository at this point
Copy the full SHA 35a4089View commit details -
Replace useUniqueId with useId (#8396)
### WHY are these changes introduced? Fixes #8395 and is blocked by #8545 ### WHAT is this pull request doing? Replaces `useUniqueId` with `useId` --------- Co-authored-by: Aaron Casanova <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 62cca13 - Browse repository at this point
Copy the full SHA 62cca13View commit details -
Configuration menu - View commit details
-
Copy full SHA for af07c6d - Browse repository at this point
Copy the full SHA af07c6dView commit details -
[Layout foundations] Replace Stack with AlphaStack (#8577)
### WHY are these changes introduced? Resolves #8102. Replaces deprecated `Stack` component with `AlphaStack`. ### WHAT is this pull request doing? - Replaces deprecated Stack with AlphaStack in `polaris-react` - Updates examples and components using AlphaStack to use Stack - Removes deprecated Stack documentation and examples - Updates AlphaStack documentation and examples ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 50e8bb5 - Browse repository at this point
Copy the full SHA 50e8bb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e80d1c7 - Browse repository at this point
Copy the full SHA e80d1c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc99b8b - Browse repository at this point
Copy the full SHA bc99b8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea8cb2a - Browse repository at this point
Copy the full SHA ea8cb2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e994a78 - Browse repository at this point
Copy the full SHA e994a78View commit details
Commits on Mar 10, 2023
-
Replace @shopify/babel-preset with using underlying configs
This commit is a non-breaking change. There are slight differences with how class properties are initialised - it removes setting them to undefined before reassigning them, which isn't needed.
Configuration menu - View commit details
-
Copy full SHA for d118c25 - Browse repository at this point
Copy the full SHA d118c25View commit details -
Remove opting into babel plugins
Now we transpile based upon our browserslist, we don't force the usage of these transpilations. In practice, given our current browserslist config this means that the following transforms are now no longer ran (for instance our compiled output now contains `foo?.bar` instead of that being transformed): - proposal-numeric-separator - proposal-nullish-coalescing-operator - proposal-optional-chaining
Configuration menu - View commit details
-
Copy full SHA for 6e750e9 - Browse repository at this point
Copy the full SHA 6e750e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cbc8b7 - Browse repository at this point
Copy the full SHA 4cbc8b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe99874 - Browse repository at this point
Copy the full SHA fe99874View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44b9887 - Browse repository at this point
Copy the full SHA 44b9887View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82ff68b - Browse repository at this point
Copy the full SHA 82ff68bView commit details -
Define our own in-repo babel configuration (#8624)
### WHY are these changes introduced? This PR replaces using `@shopify/babel-preset` with using the underlying presets directly. As part of this we simplify the plugins we use and lean more heavily on `@babel/preset-env`. As a result of this we no longer transpile numeric separators (`1_000`), nullish coalescing operators (`foo ?? 'bar'`) and optional chaining `foo?.bar` because our browserslist targets say that those features are all supported in the browsers that we target. This means that our build output now contains optional chaining et al. A breaking change side-effect of this is that code that uses these features will no longer successfully parse in webpack4, as webpack4 uses an old version of acorn does not understand these syntaxes. Webpack5 uses a newer version of acorn that can read this just fine. ### WHAT is this pull request doing? Replace `@shopify/babel-config` with using `@babel/preset-env`, `@babel/preset-typescript` and `@babel/preset-react` directly. This PR is split into two commits. The first replaces `@shopify/babel-preset` with inline config, with minimal changes. The second removes the forced compilation of the 5 plugins that were always forced to be enabled. ### How to 🎩 - Check out the main branch of polaris in your `~/projects/polaris` directory and run `cd package`, `yarn`, `yarn run turbo run build --filter='!polaris.shopify.com' --force` to produce a clean build - Check out this branch of polaris in your `~/src/github.com/Shopify/polaris` directory and run `cd package`, `yarn`, `yarn run turbo run build --filter='!polaris.shopify.com' --force` to produce a build - In the polaris in the src directory run `touch out.txt; for PACKAGENAME in $(ls -1 . | grep '^polaris-'); diff -ru ~/projects/polaris/$PACKAGENAME $PACKAGENAME -x '*.tsbuildinfo' -x '*.d.ts.map' -x'.turbo' -x '*.esnext' >> out.txt` to compare the build folder output. Note that the differences are as follows: - A handful of places where a class property is initialised to `void 0`. In all cases either the value is already implicitly undefined, or is assigned to a value shortly afterwards - Optional chaining is now left intact - Nullish coalesing is now left intact - numeric separators are now left intact --------- Co-authored-by: Alex Page <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d1c9d98 - Browse repository at this point
Copy the full SHA d1c9d98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69a0ac0 - Browse repository at this point
Copy the full SHA 69a0ac0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4da3517 - Browse repository at this point
Copy the full SHA 4da3517View commit details
Commits on Mar 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6a61bef - Browse repository at this point
Copy the full SHA 6a61befView commit details -
Configuration menu - View commit details
-
Copy full SHA for 628cc5d - Browse repository at this point
Copy the full SHA 628cc5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0b3159 - Browse repository at this point
Copy the full SHA f0b3159View commit details
Commits on Mar 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d09999c - Browse repository at this point
Copy the full SHA d09999cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce3542c - Browse repository at this point
Copy the full SHA ce3542cView commit details