Rebuild DropZone so it accesses ref.current instead of querySelector #8545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
force-pushed
the
dropzone-useref
branch
from
cc33d5b
to
cc2dd91
Compare
…d component Co-Authored-By: Aaron Casanova <[email protected]>
alex-page
force-pushed
the
dropzone-useref
branch
from
cc2dd91
to
bfc7752
Compare
alex-page
commented
Mar 3, 2023
| @@ -35,6 +34,8 @@ import styles from './DropZone.scss'; | |||
|
|
|||
| export type DropZoneFileType = 'file' | 'image' | 'video'; | |||
|
|
|||
| type DropZoneEvent = Event | React.ChangeEvent<HTMLInputElement>; | |||
There was a problem hiding this comment.
This could be exported and used in utils/index.ts. For now it's duplicated 🤷
alex-page
changed the title
size-limit report 📦
|
dleroux
approved these changes
Mar 6, 2023
Merged
kyledurand
pushed a commit
that referenced
this pull request
Mar 7, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#8546](#8546) [`8872c0861`](8872c08) Thanks [@MindRave](https://github.com/MindRave)! - Added "magic" color to the Icon component's color prop type. - [#8545](#8545) [`7c174e47a`](7c174e4) Thanks [@alex-page](https://github.com/alex-page)! - Updated DropZone with a signifigant restructure to remove Class child component - [#8525](#8525) [`8a4de8168`](8a4de81) Thanks [@rcaplanshopify](https://github.com/rcaplanshopify)! - [IndexTable] Adds support for header config object alignment property and treatment of right-aligned, sortable column headings - [#8569](#8569) [`646fba23f`](646fba2) Thanks [@kyledurand](https://github.com/kyledurand)! - Allowed aria attributes on Bleed, Inline, and Columns ### Patch Changes - [#8581](#8581) [`336d14545`](336d145) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed a bug where bulk actions wouldn't render when only promoted actions exist ## @shopify/[email protected] ## [email protected] ### Patch Changes - [#8570](#8570) [`45ca38d41`](45ca38d) Thanks [@laurkim](https://github.com/laurkim)! - Added `Legacy` status to component lifecycle page and banner/badge to `LegacyStack` and `LegacyCard` - [#8573](#8573) [`0389fd8b8`](0389fd8) Thanks [@laurkim](https://github.com/laurkim)! - Fixed links to component lifecycle page in alpha component banners - Updated dependencies \[[`336d14545`](336d145), [`8872c0861`](8872c08), [`7c174e47a`](7c174e4), [`8a4de8168`](8a4de81), [`646fba23f`](646fba2)]: - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
alex-page
added a commit
that referenced
this pull request
Mar 8, 2023
### WHY are these changes introduced? Fixes #8395 and is blocked by #8545 ### WHAT is this pull request doing? Replaces `useUniqueId` with `useId` --------- Co-authored-by: Aaron Casanova <[email protected]>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
…hopify#8545) ### WHY are these changes introduced? This is needed when removing the `useUniqId` from v11. ### WHAT is this pull request doing? - [x] Replace addEventListener with `useEventListener` hook - [x] Adjust types so that they work for all the different events - [x] Removes the child class component and moves it's logic into the parent - [x] Removes the `open()` `getElement` code and uses a ref for the input ### How to 🎩 - [ ] Thoroughly test the DropZone storybook examples in Firefox, Chrome and Safari - [ ] In particular make sure the `Upload` button works in `all-components-dropzone--with-custom-file-dialog-trigger` ### 🎩 checklist - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Aaron Casanova <[email protected]>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [Shopify#8546](Shopify#8546) [`8872c0861`](Shopify@8872c08) Thanks [@MindRave](https://github.com/MindRave)! - Added "magic" color to the Icon component's color prop type. - [Shopify#8545](Shopify#8545) [`7c174e47a`](Shopify@7c174e4) Thanks [@alex-page](https://github.com/alex-page)! - Updated DropZone with a signifigant restructure to remove Class child component - [Shopify#8525](Shopify#8525) [`8a4de8168`](Shopify@8a4de81) Thanks [@rcaplanshopify](https://github.com/rcaplanshopify)! - [IndexTable] Adds support for header config object alignment property and treatment of right-aligned, sortable column headings - [Shopify#8569](Shopify#8569) [`646fba23f`](Shopify@646fba2) Thanks [@kyledurand](https://github.com/kyledurand)! - Allowed aria attributes on Bleed, Inline, and Columns ### Patch Changes - [Shopify#8581](Shopify#8581) [`336d14545`](Shopify@336d145) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed a bug where bulk actions wouldn't render when only promoted actions exist ## @shopify/[email protected] ## [email protected] ### Patch Changes - [Shopify#8570](Shopify#8570) [`45ca38d41`](Shopify@45ca38d) Thanks [@laurkim](https://github.com/laurkim)! - Added `Legacy` status to component lifecycle page and banner/badge to `LegacyStack` and `LegacyCard` - [Shopify#8573](Shopify#8573) [`0389fd8b8`](Shopify@0389fd8) Thanks [@laurkim](https://github.com/laurkim)! - Fixed links to component lifecycle page in alpha component banners - Updated dependencies \[[`336d14545`](Shopify@336d145), [`8872c0861`](Shopify@8872c08), [`7c174e47a`](Shopify@7c174e4), [`8a4de8168`](Shopify@8a4de81), [`646fba23f`](Shopify@646fba2)]: - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This is needed when removing the
useUniqIdfrom v11.WHAT is this pull request doing?
useEventListenerhookopen()getElementcode and uses a ref for the inputHow to 🎩
Uploadbutton works inall-components-dropzone--with-custom-file-dialog-trigger🎩 checklist
README.mdwith documentation changes