Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Layout foundations] [Beta] Replace Card with AlphaCard #8101

Closed
Tracked by #8100
sarahill opened this issue Jan 19, 2023 · 1 comment · Fixed by #8468
Closed
Tracked by #8100

[Layout foundations] [Beta] Replace Card with AlphaCard #8101

sarahill opened this issue Jan 19, 2023 · 1 comment · Fixed by #8468
Assignees
@laurkim

Comments

@sarahill
Copy link
Contributor

No description provided.

@sarahill sarahill changed the title Deprecate or replace Card [Layout foundations] Deprecate or replace Card Jan 19, 2023
@sarahill sarahill changed the title [Layout foundations] Deprecate or replace Card [Layout foundations] [Beta] Deprecate or replace Card Jan 19, 2023
@laurkim laurkim mentioned this issue Jan 19, 2023
Closed
@laurkim laurkim changed the title [Layout foundations] [Beta] Deprecate or replace Card [Layout foundations] [Beta] Rename AlphaCard to Card Jan 27, 2023
@aveline aveline assigned aveline and unassigned aveline Jan 30, 2023
@laurkim laurkim self-assigned this Feb 22, 2023
@laurkim laurkim mentioned this issue Feb 22, 2023
Merged
5 tasks
@laurkim laurkim linked a pull request Feb 22, 2023 that will close this issue
[Layout foundations] Replace Card with AlphaCard #8468
Merged
5 tasks
@laurkim laurkim changed the title [Layout foundations] [Beta] Rename AlphaCard to Card [Layout foundations] [Beta] Replace Card with AlphaCard Feb 22, 2023
laurkim added a commit that referenced this issue Feb 22, 2023
@laurkim
[Layout foundations] Replace Card with AlphaCard (#8468)
5985838 
### WHY are these changes introduced?

Resolves #8458, #8101, and #8376.

Replaces `Card` with `AlphaCard`.

### WHAT is this pull request doing?

- Replace Card with AlphaCard in polaris-react
- Removes Card and examples in polaris.shopify.com
- Updates any card links in style guide (links to content specifically
in the `card.md` file was updated to point to `legacy-card.md`)
- Removes temporary support for `Polaris-Card` class overrides in
`LegacyCard`

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [x] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@laurkim
Copy link
Contributor

laurkim commented Feb 22, 2023

Closed with #8468

@laurkim laurkim closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurkim laurkim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Layout foundations] Replace Card with AlphaCard Shopify/polaris
4 participants
@aveline @sarahill @alex-page @laurkim