Update rollup and babel to latest versions #8200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
commented
Jan 29, 2023
Comment on lines
-51
to
-54
| "@rollup/plugin-babel": "^5.3.1", | ||
| "@rollup/plugin-commonjs": "^22.0.2", | ||
| "@rollup/plugin-json": "^4.1.0", | ||
| "@rollup/plugin-node-resolve": "^13.3.0", |
size-limit report 📦
|
alex-page
commented
Jan 29, 2023
| @@ -21,14 +21,14 @@ export default { | |||
| output: [ | |||
| { | |||
| format: /** @type {const} */ ('cjs'), | |||
| entryFileNames: '[name][assetExtname].js', | |||
There was a problem hiding this comment.
[assetExtname] no longer exists in the latest version of rollup.
Note that in this case,
[name]will include the relative path from the output root and possibly the original file extension if it was not one of.js,.jsx,.mjs,.cjs,.ts,.tsx,.mts, or.cts.
https://rollupjs.org/configuration-options/#output-entryfilenames
alex-page
commented
Jan 29, 2023
Comment on lines
-234
to
-242
| manualChunks: (id) => { | ||
| // Generate distinct chunks for each icon | ||
| // This allows consuming apps to split up the icons into multiple subchunks | ||
| // containing a few icons each instead of always having to put every icon | ||
| // into a single shared chunk | ||
| if (id.startsWith(iconBasePath)) { | ||
| return id.replace(iconBasePath, 'icons/'); | ||
| } | ||
| }, |
There was a problem hiding this comment.
manualChunks is going to move to output in the next breaking change. This moves it now so we don't have to fix it later.
alex-page
requested review from
aaronccasanova and
sam-b-rose
and removed request for
aaronccasanova
jesstelford
approved these changes
Jan 29, 2023
|
I am going to merge this into v11. Please still take a look/review I will be happy to iterate in a follow up PR. |
23 tasks
alex-page
changed the title
alex-page
changed the title
sam-b-rose
added a commit
that referenced
this pull request
May 26, 2023
## @shopify/polaris v11.0.0 ### Dependencies - [x] #8200 ### NodeJS - [x] #8201 ### TypeScript - [x] #8203 ### Components - [x] #7349 - [x] #7397 - [x] #7962 - [x] #8187 - [x] #8184 - [x] #8206 - [x] #7990 - [x] #8468 - [x] #8577 - [x] #8631 - [x] #8962 ## @shopify/polaris-tokens v7.0.0 ### Tokens - [x] #6920 - [x] #8245 - [x] #4826 - [x] #8405 ## @shopify/stylelint-polaris v7.0.0 - [x] #7622 - [x] #8419 # Post @shopify/polaris v11 shipping - [ ] #8420 ## Low priority or not ready breaking changes - [x] Remove deprecated layout components - [x] Release Layout primitive components --------- Co-authored-by: Tim Layton <[email protected]> Co-authored-by: Ryan Musgrave <[email protected]> Co-authored-by: Ryan Musgrave <[email protected]> Co-authored-by: aveline <[email protected]> Co-authored-by: Kyle Durand <[email protected]> Co-authored-by: Matt Gregg <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Lo Kim <[email protected]> Co-authored-by: Ben Scott <[email protected]> Co-authored-by: Aaron Casanova <[email protected]> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Marc Thomas <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Joe Thomas <[email protected]> Co-authored-by: Yuraima Estevez <[email protected]> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
## @shopify/polaris v11.0.0 ### Dependencies - [x] Shopify#8200 ### NodeJS - [x] Shopify#8201 ### TypeScript - [x] Shopify#8203 ### Components - [x] Shopify#7349 - [x] Shopify#7397 - [x] Shopify#7962 - [x] Shopify#8187 - [x] Shopify#8184 - [x] Shopify#8206 - [x] Shopify#7990 - [x] Shopify#8468 - [x] Shopify#8577 - [x] Shopify#8631 - [x] Shopify#8962 ## @shopify/polaris-tokens v7.0.0 ### Tokens - [x] Shopify#6920 - [x] Shopify#8245 - [x] Shopify#4826 - [x] Shopify#8405 ## @shopify/stylelint-polaris v7.0.0 - [x] Shopify#7622 - [x] Shopify#8419 # Post @shopify/polaris v11 shipping - [ ] Shopify#8420 ## Low priority or not ready breaking changes - [x] Remove deprecated layout components - [x] Release Layout primitive components --------- Co-authored-by: Tim Layton <[email protected]> Co-authored-by: Ryan Musgrave <[email protected]> Co-authored-by: Ryan Musgrave <[email protected]> Co-authored-by: aveline <[email protected]> Co-authored-by: Kyle Durand <[email protected]> Co-authored-by: Matt Gregg <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Lo Kim <[email protected]> Co-authored-by: Ben Scott <[email protected]> Co-authored-by: Aaron Casanova <[email protected]> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Marc Thomas <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Joe Thomas <[email protected]> Co-authored-by: Yuraima Estevez <[email protected]> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Rollup and Babel are blocking our migration to minimum NodeJS version 16.
This PR updated all Rollup and Babel dependencies. These NPM package upgrades are not compatible with NodeJS 14.17 (main branch version). This change unblocks a larger change to our NodeJS versions.
WHAT is this pull request doing?
How to 🎩
mainsave the built files on desktopbump-build-depssave the built files on desktop@alex-page's output from Diff: diff.zip
🎩 checklist
README.mdwith documentation changes