Add new z-index token names #8245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alex-page
approved these changes
Feb 2, 2023
alex-page
reviewed
Feb 2, 2023
Co-authored-by: Alex Page <[email protected]>
lgriffee
commented
Feb 2, 2023
aaronccasanova
approved these changes
Feb 2, 2023
Co-authored-by: Aaron Casanova <[email protected]>
23 tasks
Merged
laurkim
pushed a commit
that referenced
this pull request
Feb 3, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#8240](#8240) [`31abdab37`](31abdab) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack` component - [#8238](#8238) [`bb8b551d4`](bb8b551) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard` component ### Patch Changes - [#8256](#8256) [`43776be71`](43776be) Thanks [@aveline](https://github.com/aveline)! - - Fixed `Bleed` width behavior - Fixed `Banner` content width - [#8244](#8244) [`0ee432500`](0ee4325) Thanks [@samrose3](https://github.com/samrose3)! - Disallow text-transform property in Stylelint Polaris - Updated dependencies \[[`1b1394d32`](1b1394d)]: - @shopify/[email protected] ## @shopify/[email protected] ### Minor Changes - [#8245](#8245) [`1b1394d32`](1b1394d) Thanks [@lgriffee](https://github.com/lgriffee)! - Added new z-index tokens that will be the default in v7.0.0 ## @shopify/[email protected] ### Minor Changes - [#8244](#8244) [`0ee432500`](0ee4325) Thanks [@samrose3](https://github.com/samrose3)! - Disallow text-transform property in Stylelint Polaris ### Patch Changes - Updated dependencies \[[`1b1394d32`](1b1394d)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`1b1394d32`](1b1394d), [`0ee432500`](0ee4325)]: - @shopify/[email protected] - @shopify/[email protected] ## [email protected] ### Minor Changes - [#8240](#8240) [`31abdab37`](31abdab) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack` component - [#8238](#8238) [`bb8b551d4`](bb8b551) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard` component ### Patch Changes - Updated dependencies \[[`43776be71`](43776be), [`31abdab37`](31abdab), [`1b1394d32`](1b1394d), [`0ee432500`](0ee4325), [`bb8b551d4`](bb8b551)]: - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
Closed
sam-b-rose
added a commit
that referenced
this pull request
May 26, 2023
## @shopify/polaris v11.0.0 ### Dependencies - [x] #8200 ### NodeJS - [x] #8201 ### TypeScript - [x] #8203 ### Components - [x] #7349 - [x] #7397 - [x] #7962 - [x] #8187 - [x] #8184 - [x] #8206 - [x] #7990 - [x] #8468 - [x] #8577 - [x] #8631 - [x] #8962 ## @shopify/polaris-tokens v7.0.0 ### Tokens - [x] #6920 - [x] #8245 - [x] #4826 - [x] #8405 ## @shopify/stylelint-polaris v7.0.0 - [x] #7622 - [x] #8419 # Post @shopify/polaris v11 shipping - [ ] #8420 ## Low priority or not ready breaking changes - [x] Remove deprecated layout components - [x] Release Layout primitive components --------- Co-authored-by: Tim Layton <[email protected]> Co-authored-by: Ryan Musgrave <[email protected]> Co-authored-by: Ryan Musgrave <[email protected]> Co-authored-by: aveline <[email protected]> Co-authored-by: Kyle Durand <[email protected]> Co-authored-by: Matt Gregg <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Lo Kim <[email protected]> Co-authored-by: Ben Scott <[email protected]> Co-authored-by: Aaron Casanova <[email protected]> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Marc Thomas <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Joe Thomas <[email protected]> Co-authored-by: Yuraima Estevez <[email protected]> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
<!--
☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
- Start with a verb, for example: Add, Delete, Improve, Fix…
- Give as much context as necessary and as little as possible
- Prefix it with [WIP] while it’s a work in progress
-->
### WHY are these changes introduced?
We want to rename these tokens in v11. By adding the new names in v10 we
can break up the major version bump into more manageable chunks (we can
create and run migrations for the values in v10 and then just remove the
values in the launch of v11).
<!--
Context about the problem that’s being addressed.
-->
### WHAT is this pull request doing?
<!--
Summary of the changes committed.
Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.
If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:
<details>
<summary>Summary of your gif(s)</summary>
<img src="..." alt="Description of what the gif shows">
</details>
-->
<!-- ℹ️ Delete the following for small / trivial changes -->
Adds a set of identical z-index tokens with the names `--p-z-index-*`
(vs. `--p-z-*`)
---------
Co-authored-by: Alex Page <[email protected]>
Co-authored-by: Aaron Casanova <[email protected]>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [Shopify#8240](Shopify#8240) [`31abdab37`](Shopify@31abdab) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack` component - [Shopify#8238](Shopify#8238) [`bb8b551d4`](Shopify@bb8b551) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard` component ### Patch Changes - [Shopify#8256](Shopify#8256) [`43776be71`](Shopify@43776be) Thanks [@aveline](https://github.com/aveline)! - - Fixed `Bleed` width behavior - Fixed `Banner` content width - [Shopify#8244](Shopify#8244) [`0ee432500`](Shopify@0ee4325) Thanks [@samrose3](https://github.com/samrose3)! - Disallow text-transform property in Stylelint Polaris - Updated dependencies \[[`1b1394d32`](Shopify@1b1394d)]: - @shopify/[email protected] ## @shopify/[email protected] ### Minor Changes - [Shopify#8245](Shopify#8245) [`1b1394d32`](Shopify@1b1394d) Thanks [@lgriffee](https://github.com/lgriffee)! - Added new z-index tokens that will be the default in v7.0.0 ## @shopify/[email protected] ### Minor Changes - [Shopify#8244](Shopify#8244) [`0ee432500`](Shopify@0ee4325) Thanks [@samrose3](https://github.com/samrose3)! - Disallow text-transform property in Stylelint Polaris ### Patch Changes - Updated dependencies \[[`1b1394d32`](Shopify@1b1394d)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`1b1394d32`](Shopify@1b1394d), [`0ee432500`](Shopify@0ee4325)]: - @shopify/[email protected] - @shopify/[email protected] ## [email protected] ### Minor Changes - [Shopify#8240](Shopify#8240) [`31abdab37`](Shopify@31abdab) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack` component - [Shopify#8238](Shopify#8238) [`bb8b551d4`](Shopify@bb8b551) Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard` component ### Patch Changes - Updated dependencies \[[`43776be71`](Shopify@43776be), [`31abdab37`](Shopify@31abdab), [`1b1394d32`](Shopify@1b1394d), [`0ee432500`](Shopify@0ee4325), [`bb8b551d4`](Shopify@bb8b551)]: - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
## @shopify/polaris v11.0.0 ### Dependencies - [x] Shopify#8200 ### NodeJS - [x] Shopify#8201 ### TypeScript - [x] Shopify#8203 ### Components - [x] Shopify#7349 - [x] Shopify#7397 - [x] Shopify#7962 - [x] Shopify#8187 - [x] Shopify#8184 - [x] Shopify#8206 - [x] Shopify#7990 - [x] Shopify#8468 - [x] Shopify#8577 - [x] Shopify#8631 - [x] Shopify#8962 ## @shopify/polaris-tokens v7.0.0 ### Tokens - [x] Shopify#6920 - [x] Shopify#8245 - [x] Shopify#4826 - [x] Shopify#8405 ## @shopify/stylelint-polaris v7.0.0 - [x] Shopify#7622 - [x] Shopify#8419 # Post @shopify/polaris v11 shipping - [ ] Shopify#8420 ## Low priority or not ready breaking changes - [x] Remove deprecated layout components - [x] Release Layout primitive components --------- Co-authored-by: Tim Layton <[email protected]> Co-authored-by: Ryan Musgrave <[email protected]> Co-authored-by: Ryan Musgrave <[email protected]> Co-authored-by: aveline <[email protected]> Co-authored-by: Kyle Durand <[email protected]> Co-authored-by: Matt Gregg <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Lo Kim <[email protected]> Co-authored-by: Ben Scott <[email protected]> Co-authored-by: Aaron Casanova <[email protected]> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Marc Thomas <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Joe Thomas <[email protected]> Co-authored-by: Yuraima Estevez <[email protected]> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We want to rename these tokens in v11. By adding the new names in v10 we can break up the major version bump into more manageable chunks (we can create and run migrations for the values in v10 and then just remove the values in the launch of v11).
WHAT is this pull request doing?
Adds a set of identical z-index tokens with the names
--p-z-index-*(vs.--p-z-*)