-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Layout foundations] Clean up css in LegacyCard
#8376
Comments
5 tasks
5 tasks
5 tasks
laurkim
added a commit
that referenced
this issue
Feb 22, 2023
### WHY are these changes introduced? Resolves #8458, #8101, and #8376. Replaces `Card` with `AlphaCard`. ### WHAT is this pull request doing? - Replace Card with AlphaCard in polaris-react - Removes Card and examples in polaris.shopify.com - Updates any card links in style guide (links to content specifically in the `card.md` file was updated to point to `legacy-card.md`) - Removes temporary support for `Polaris-Card` class overrides in `LegacyCard` ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Closed with #8468. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Remove: https://github.com/Shopify/polaris/blob/main/polaris-react/src/components/Card/Card.scss#L16-L22
Remove: https://github.com/Shopify/polaris/blob/main/polaris-react/src/components/LegacyCard/LegacyCard.scss#L16-L22
Remove Polaris-Card css overrides in admin.
The text was updated successfully, but these errors were encountered: