Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change breadcrumb to backlink #8465

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Change breadcrumb to backlink #8465

merged 4 commits into from
Feb 23, 2023

Conversation

itwasmattgregg
Copy link
Contributor

@itwasmattgregg itwasmattgregg commented Feb 22, 2023 •
edited
Loading

WHY are these changes introduced?

Adjusting the syntax of the v11 change to backLink

Also note that breadcrumbs are no longer supported in v11.

WHAT is this pull request doing?

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx: 
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@itwasmattgregg itwasmattgregg force-pushed the breadcrumb-prop-backLink branch 2 times, most recently from 1ad3b52 to 7405cd1 Compare February 22, 2023 21:18
@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2023 •
edited
Loading

size-limit report 📦

Path Size
polaris-react-cjs 215.63 KB (-0.05% 🔽)
polaris-react-esm 138.58 KB (-0.08% 🔽)
polaris-react-esnext 193.27 KB (-0.06% 🔽)
polaris-react-css 41.61 KB (0%)

@itwasmattgregg itwasmattgregg force-pushed the breadcrumb-prop-backLink branch from caebc9f to 24c07b4 Compare February 23, 2023 05:39
sam-b-rose
sam-b-rose approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just need to update the AppProvider story from backLink to backAction 👍

@sam-b-rose sam-b-rose mentioned this pull request Feb 23, 2023
Merged
@itwasmattgregg itwasmattgregg force-pushed the breadcrumb-prop-backLink branch from 24c07b4 to c318f03 Compare February 23, 2023 17:58
@itwasmattgregg itwasmattgregg self-assigned this Feb 23, 2023
itwasmattgregg added a commit that referenced this pull request Feb 23, 2023
@itwasmattgregg @sam-b-rose
Add v11 breadcrumb migration docs (#8466)
3b32f34 
### WHY are these changes introduced?

After we add the new migrator we should publish these docs.

Related: #8071 #8465

---------

Co-authored-by: Sam Rose <[email protected]>
@itwasmattgregg itwasmattgregg merged commit 68fd9c0 into v11-major Feb 23, 2023
@itwasmattgregg itwasmattgregg deleted the breadcrumb-prop-backLink branch February 23, 2023 19:34
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@itwasmattgregg @sam-b-rose @juzser
Add v11 breadcrumb migration docs (Shopify#8466)
391ce03 
### WHY are these changes introduced?

After we add the new migrator we should publish these docs.

Related: Shopify#8071 Shopify#8465

---------

Co-authored-by: Sam Rose <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-b-rose sam-b-rose sam-b-rose approved these changes

@alex-page alex-page alex-page approved these changes

@kyledurand kyledurand Awaiting requested review from kyledurand

Assignees

@itwasmattgregg itwasmattgregg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itwasmattgregg @sam-b-rose @alex-page