-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated typography components #8184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
laurkim
requested review from
alex-page,
sam-b-rose,
aaronccasanova,
kyledurand,
aveline and
sarahill
January 27, 2023 14:49
kyledurand
approved these changes
Jan 27, 2023
aveline
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
23 tasks
Legend. |
4 tasks
sam-b-rose
added a commit
that referenced
this pull request
May 26, 2023
## @shopify/polaris v11.0.0 ### Dependencies - [x] #8200 ### NodeJS - [x] #8201 ### TypeScript - [x] #8203 ### Components - [x] #7349 - [x] #7397 - [x] #7962 - [x] #8187 - [x] #8184 - [x] #8206 - [x] #7990 - [x] #8468 - [x] #8577 - [x] #8631 - [x] #8962 ## @shopify/polaris-tokens v7.0.0 ### Tokens - [x] #6920 - [x] #8245 - [x] #4826 - [x] #8405 ## @shopify/stylelint-polaris v7.0.0 - [x] #7622 - [x] #8419 # Post @shopify/polaris v11 shipping - [ ] #8420 ## Low priority or not ready breaking changes - [x] Remove deprecated layout components - [x] Release Layout primitive components --------- Co-authored-by: Tim Layton <[email protected]> Co-authored-by: Ryan Musgrave <[email protected]> Co-authored-by: Ryan Musgrave <[email protected]> Co-authored-by: aveline <[email protected]> Co-authored-by: Kyle Durand <[email protected]> Co-authored-by: Matt Gregg <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Lo Kim <[email protected]> Co-authored-by: Ben Scott <[email protected]> Co-authored-by: Aaron Casanova <[email protected]> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Marc Thomas <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Joe Thomas <[email protected]> Co-authored-by: Yuraima Estevez <[email protected]> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
## @shopify/polaris v11.0.0 ### Dependencies - [x] Shopify#8200 ### NodeJS - [x] Shopify#8201 ### TypeScript - [x] Shopify#8203 ### Components - [x] Shopify#7349 - [x] Shopify#7397 - [x] Shopify#7962 - [x] Shopify#8187 - [x] Shopify#8184 - [x] Shopify#8206 - [x] Shopify#7990 - [x] Shopify#8468 - [x] Shopify#8577 - [x] Shopify#8631 - [x] Shopify#8962 ## @shopify/polaris-tokens v7.0.0 ### Tokens - [x] Shopify#6920 - [x] Shopify#8245 - [x] Shopify#4826 - [x] Shopify#8405 ## @shopify/stylelint-polaris v7.0.0 - [x] Shopify#7622 - [x] Shopify#8419 # Post @shopify/polaris v11 shipping - [ ] Shopify#8420 ## Low priority or not ready breaking changes - [x] Remove deprecated layout components - [x] Release Layout primitive components --------- Co-authored-by: Tim Layton <[email protected]> Co-authored-by: Ryan Musgrave <[email protected]> Co-authored-by: Ryan Musgrave <[email protected]> Co-authored-by: aveline <[email protected]> Co-authored-by: Kyle Durand <[email protected]> Co-authored-by: Matt Gregg <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Lo Kim <[email protected]> Co-authored-by: Ben Scott <[email protected]> Co-authored-by: Aaron Casanova <[email protected]> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Marc Thomas <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Joe Thomas <[email protected]> Co-authored-by: Yuraima Estevez <[email protected]> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves #6511.
Now that
Shopify/web
has been migrated to use theText
component, we can safely remove the 6 deprecated typography components.Note: The 3 chromatic changes are related to other changes in the v11 branch and not this PR.
WHAT is this pull request doing?
Removes
DisplayText
,Heading
,Subheading
,Caption
,TextStyle
, andVisuallyHidden
.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changes